From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: Jonathan Denose <jdenose@google.com>
Cc: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <bentiss@kernel.org>,
Thorsten Leemhuis <linux@leemhuis.info>,
Randy Dunlap <rdunlap@infradead.org>,
Lucas GISSOT <lucas.gissot.pro@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: Kconfig: Fix build error from CONFIG_HID_HAPTIC
Date: Tue, 14 Oct 2025 05:29:37 +0800 [thread overview]
Message-ID: <aO1vQYCKU7fA0Fxm@visitorckw-System-Product-Name> (raw)
In-Reply-To: <CAMCVhVNLr+2ivRo9T4rVt4mkncwbOfXEL9bE=pDGRp=Qjy1c9A@mail.gmail.com>
On Mon, Oct 13, 2025 at 04:23:36PM -0500, Jonathan Denose wrote:
> On Mon, Oct 13, 2025 at 4:11 PM Kuan-Wei Chiu <visitorckw@gmail.com> wrote:
> >
> > On Mon, Oct 13, 2025 at 08:54:57PM +0000, Jonathan Denose wrote:
> > > Temporarily change CONFIG_HID_HAPTIC to be bool instead of tristate, until
> > > we implement a permanent solution.
> > >
> > > ---
> >
> > The "---" line here will cause many tools used for applying patches,
> > like git am, to discard the content below it [1].
> >
> > Please don't add this line unless you don't want the following content
> > to appear in the commit message.
> >
> > [1]: https://www.kernel.org/doc/html/v6.17/process/submitting-patches.html#commentary
> >
> > Regards,
> > Kuan-Wei
>
> Yes, that was intentional, the information below the '---' was
> included as additional information and not for the commit message. The
> error messages were too long, as was the link to the longer
> discussion, and this caused errors in checkpatch.pl.
>
Then at least your Signed-off-by tag needs to be above the --- line?
Regards,
Kuan-Wei
next prev parent reply other threads:[~2025-10-13 21:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 20:54 [PATCH] HID: Kconfig: Fix build error from CONFIG_HID_HAPTIC Jonathan Denose
2025-10-13 21:10 ` Kuan-Wei Chiu
2025-10-13 21:23 ` Jonathan Denose
2025-10-13 21:29 ` Kuan-Wei Chiu [this message]
2025-10-14 1:24 ` Randy Dunlap
2025-10-14 8:48 ` Thorsten Leemhuis
2025-10-14 10:09 ` Jiri Kosina
2025-10-14 16:54 ` Jonathan Denose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aO1vQYCKU7fA0Fxm@visitorckw-System-Product-Name \
--to=visitorckw@gmail.com \
--cc=bentiss@kernel.org \
--cc=jdenose@google.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=lucas.gissot.pro@gmail.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).