linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adrien Kunysz <adrien@kunysz.be>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: controller is wrongly labelled as "Generic X-Box pad"
Date: Thu, 11 Dec 2025 19:07:04 +0100	[thread overview]
Message-ID: <aTsISNi0WZb8YCGA@rodenbach> (raw)

Hello,

I have a game controller that is wrongly recognised as a "Generic X-Box pad".
It is clearly a PS4 controller but the xpad driver works fine.

The physical label on the controller says "Nacon Revolution Unlimited Pro Controller".
dmesg reports its name as "Generic X-Box pad".
lsusb says "BigBen Interactive Revolution Unlimited Pro Controller".

I am unclear what the "mapping", "xtype" and "packet_type" fields should be or
whether this controller should be handled by another driver but I do know the
"name" field is wrong. So I propose to fix it.

--- a/drivers/input/joystick/xpad.c 2025-10-29 14:04:43.000000000 +0100
+++ b/drivers/input/joystick/xpad.c 2025-12-11 17:20:28.733440851 +0100
@@ -286,6 +286,7 @@ static const struct xpad_device {
        { 0x1430, 0xf801, "RedOctane Controller", 0, XTYPE_XBOX360 },
        { 0x146b, 0x0601, "BigBen Interactive XBOX 360 Controller", 0, XTYPE_XBOX360 },
        { 0x146b, 0x0604, "Bigben Interactive DAIJA Arcade Stick", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOX360 },
+       { 0x146b, 0x0605, "Bigben Interactive Revolution Unlimited Pro Controller", 0, XTYPE_UNKNOWN },
        { 0x1532, 0x0a00, "Razer Atrox Arcade Stick", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOXONE },
        { 0x1532, 0x0a03, "Razer Wildcat", 0, XTYPE_XBOXONE },
        { 0x1532, 0x0a29, "Razer Wolverine V2", 0, XTYPE_XBOXONE },

                 reply	other threads:[~2025-12-11 18:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aTsISNi0WZb8YCGA@rodenbach \
    --to=adrien@kunysz.be \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).