From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: duoming@zju.edu.cn
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
pali@kernel.org, kuba@kernel.org, alexander.deucher@amd.com,
akpm@linux-foundation.org, johannes.berg@intel.com,
pkshih@realtek.com, hverkuil+cisco@kernel.org,
tglx@linutronix.de, mingo@kernel.org
Subject: Re: [PATCH v2 RESEND 2/2] Input: psmouse - Replace flush_workqueue() with disable_delayed_work_sync()
Date: Sat, 27 Dec 2025 17:58:05 +0200 [thread overview]
Message-ID: <aVACDawiYQDdQkhu@smile.fi.intel.com> (raw)
In-Reply-To: <67e94e29.46daa.19b31d9f861.Coremail.duoming@zju.edu.cn>
On Thu, Dec 18, 2025 at 10:25:27PM +0800, duoming@zju.edu.cn wrote:
> On Wed, 17 Dec 2025 22:58:33 -0800 Dmitry Torokhov wrote:
...
> > What do you mean? If you enable OLPC support the option to enable hgpk
> > protocol driver should become available, right?
>
> The hgpk_init() function is never called by any other function in the
> kernel and is therefore dead code. Since the delayed work item recalib_wq
> is initialized within this function, it is consequently never scheduled
> during runtime.
Actually I confirm this as of v6.19-rc2. Perhaps some patch removed some
functionality in the past and we may remove more now?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-12-27 15:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 3:00 [PATCH v2 RESEND 0/2] Input: alps/psmouse: Fix UAF bugs and improve workqueue synchronization Duoming Zhou
2025-12-17 3:00 ` [PATCH v2 RESEND 1/2] Input: alps - fix use-after-free bugs caused by dev3_register_work Duoming Zhou
2025-12-17 18:08 ` Dmitry Torokhov
2025-12-17 3:00 ` [PATCH v2 RESEND 2/2] Input: psmouse - Replace flush_workqueue() with disable_delayed_work_sync() Duoming Zhou
2025-12-17 18:13 ` Dmitry Torokhov
2025-12-18 5:49 ` duoming
2025-12-18 6:58 ` Dmitry Torokhov
2025-12-18 14:25 ` duoming
2025-12-27 15:58 ` Andy Shevchenko [this message]
2025-12-28 23:15 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aVACDawiYQDdQkhu@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.deucher@amd.com \
--cc=dmitry.torokhov@gmail.com \
--cc=duoming@zju.edu.cn \
--cc=hverkuil+cisco@kernel.org \
--cc=johannes.berg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pali@kernel.org \
--cc=pkshih@realtek.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).