Re: [PATCH] Input: pf1550 - cope for CONFIG_PM=n

[Frank Li <Frank.li@nxp.com>]

On Mon, Jan 12, 2026 at 05:13:59PM +0100, Uwe Kleine-König wrote:
> This fixes the following build failure with CONFIG_PM disabled:
>
> 	drivers/input/misc/pf1550-onkey.c:154:12: error: ‘pf1550_onkey_resume’ defined but not used [-Werror=unused-function]
> 	  154 | static int pf1550_onkey_resume(struct device *dev)
> 	      |            ^~~~~~~~~~~~~~~~~~~
> 	drivers/input/misc/pf1550-onkey.c:133:12: error: ‘pf1550_onkey_suspend’ defined but not used [-Werror=unused-function]
> 	  133 | static int pf1550_onkey_suspend(struct device *dev)
> 	      |            ^~~~~~~~~~~~~~~~~~~~
> 	cc1: all warnings being treated as errors
>
> Fixes: 9acb215cbebd ("Input: pf1550 - add onkey support")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/input/misc/pf1550-onkey.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/misc/pf1550-onkey.c b/drivers/input/misc/pf1550-onkey.c
> index 9be6377151cb..a636ceedfc04 100644
> --- a/drivers/input/misc/pf1550-onkey.c
> +++ b/drivers/input/misc/pf1550-onkey.c
> @@ -173,8 +173,8 @@ static int pf1550_onkey_resume(struct device *dev)
>  	return 0;
>  }
>
> -static SIMPLE_DEV_PM_OPS(pf1550_onkey_pm_ops, pf1550_onkey_suspend,
> -			 pf1550_onkey_resume);
> +static DEFINE_SIMPLE_DEV_PM_OPS(pf1550_onkey_pm_ops, pf1550_onkey_suspend,
> +				pf1550_onkey_resume);
>
>  static const struct platform_device_id pf1550_onkey_id[] = {
>  	{ "pf1550-onkey", },
>
> base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
> --
> 2.47.3
>