From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] Input: wdt87xx_i2c - tidy up ACPI ID table
Date: Tue, 20 Jan 2026 23:07:01 +0200 [thread overview]
Message-ID: <aW_udfdK9mMOvW1X@smile.fi.intel.com> (raw)
In-Reply-To: <nn6qjsmd4vt2giq3kd46lemd2q2ofdjbb6mmlaao7y2edodm3u@s2qwtwhyhiwb>
On Tue, Jan 20, 2026 at 12:42:16PM -0800, Dmitry Torokhov wrote:
> On Tue, Jan 13, 2026 at 09:22:57AM +0100, Andy Shevchenko wrote:
> > Tidy up ACPI ID table:
> > - drop ACPI_PTR() and hence replace acpi.h with mod_devicetable.h et al.
> > - remove explicit driver_data initializer
>
> With the exception of cleaning the driver_data is it unclear to me what
> the benefit is. The driver is potentially useful on non-ACPI systems (or
> may be easily adopted) so making ACPI not optional does not sound like
> improvement...
I'm not sure how you came to the conclusion "making ACPI not optional".
This is just matter of dozens of bytes in the binary, it doesn't affect
functionality neither on ACPI-based, nor on non-ACPI platforms.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-20 21:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 8:22 [PATCH v2 0/2] Input: wdt87xx_i2c - a couple of cleanups Andy Shevchenko
2026-01-13 8:22 ` [PATCH v2 1/2] Input: wdt87xx_i2c - tidy up ACPI ID table Andy Shevchenko
2026-01-20 20:42 ` Dmitry Torokhov
2026-01-20 21:07 ` Andy Shevchenko [this message]
2026-01-13 8:22 ` [PATCH v2 2/2] Input: wdt87xx_i2c - switch to use dev_err_probe() Andy Shevchenko
2026-01-20 20:40 ` Dmitry Torokhov
2026-01-20 21:09 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aW_udfdK9mMOvW1X@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox