From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Lee Jones" <lee@kernel.org>, "Pavel Machek" <pavel@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Dixit Parmar" <dixitparmar19@gmail.com>,
"Tony Lindgren" <tony@atomide.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
linux-leds@vger.kernel.org, linux-rtc@vger.kernel.org
Subject: Re: [PATCH v1 02/10] regulator: cpcap-regulator: add support for Mot regulators
Date: Mon, 26 Jan 2026 12:10:39 +0200 [thread overview]
Message-ID: <aXc9n_gc7TEFvNA8@smile.fi.intel.com> (raw)
In-Reply-To: <20260125134302.45958-3-clamor95@gmail.com>
On Sun, Jan 25, 2026 at 03:42:54PM +0200, Svyatoslav Ryhel wrote:
> Add support for regulator set used in Motorola Mot board, used as a base
> for Atrix 4G and Droid X2 smartphones.
...
> +static const unsigned int sw_mot_val_tbl[] = { 600000, 612500, 625000,
> + 637500, 650000, 662500,
> + 675000, 687500, 700000,
> + 712500, 725000, 737500,
> + 750000, 762500, 775000,
> + 787500, 800000, 812500,
> + 825000, 837500, 850000,
> + 862500, 875000, 887500,
> + 900000, 912500, 925000,
> + 937500, 950000, 962500,
> + 975000, 987500, 1000000,
> + 1012500, 1025000, 1037500,
> + 1050000, 1062500, 1075000,
> + 1087500, 1100000, 1112500,
> + 1125000, 1137500, 1150000,
> + 1162500, 1175000, 1187500,
> + 1200000, 1212500, 1225000,
> + 1237500, 1250000, 1262500,
> + 1275000, 1287500, 1300000,
> + 1312500, 1325000, 1337500,
> + 1350000, 1362500, 1375000,
> + 1387500, 1400000, 1412500,
> + 1425000, 1437500, 1450000,
> + 1462500, 1475000, };
What a style! (Yeah, I see it's being used elsewhere here...)
...
> + CPCAP_REG(VAUDIO, CPCAP_REG_VAUDIOC, CPCAP_REG_ASSIGN4,
> + CPCAP_BIT_VAUDIO_SEL, vaudio_val_tbl,
> + 0x16, 0x1, 0x5, 0, 0),
> + { /* sentinel */ },
No trailing comma for sentinel.
> +};
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-26 10:10 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-25 13:42 [PATCH v1 00/10] mfd: cpcap: convert documentation to schema and add Mot board support Svyatoslav Ryhel
2026-01-25 13:42 ` [PATCH v1 01/10] dt-bindings: regulator: cpcap-regulator: convert to schema Svyatoslav Ryhel
2026-01-31 19:46 ` David Lechner
2026-01-31 19:55 ` David Lechner
2026-02-01 7:01 ` Svyatoslav Ryhel
2026-02-01 7:01 ` Svyatoslav Ryhel
2026-01-25 13:42 ` [PATCH v1 02/10] regulator: cpcap-regulator: add support for Mot regulators Svyatoslav Ryhel
2026-01-26 10:10 ` Andy Shevchenko [this message]
2026-01-26 10:13 ` Svyatoslav Ryhel
2026-01-26 11:50 ` Andy Shevchenko
2026-01-25 13:42 ` [PATCH v1 03/10] dt-bindings: iio: adc: cpcap-adc: document Mot ADC Svyatoslav Ryhel
2026-01-31 19:48 ` David Lechner
2026-01-31 19:50 ` David Lechner
2026-02-06 13:31 ` Rob Herring (Arm)
2026-01-25 13:42 ` [PATCH v1 04/10] iio: adc: cpcap-adc: add support for " Svyatoslav Ryhel
2026-01-26 10:11 ` Andy Shevchenko
2026-01-25 13:42 ` [PATCH v1 05/10] dt-bindings: leds: leds-cpcap: convert to schema Svyatoslav Ryhel
2026-01-31 19:59 ` David Lechner
2026-02-06 13:33 ` Rob Herring (Arm)
2026-01-25 13:42 ` [PATCH v1 06/10] dt-bindings: rtc: cpcap-rtc: " Svyatoslav Ryhel
2026-01-25 16:28 ` Rob Herring (Arm)
2026-01-30 22:59 ` (subset) " Alexandre Belloni
2026-01-25 13:42 ` [PATCH v1 07/10] dt-bindings: input: cpcap-pwrbutton: " Svyatoslav Ryhel
2026-01-25 16:43 ` Rob Herring (Arm)
2026-01-31 20:02 ` David Lechner
2026-02-01 7:07 ` Svyatoslav Ryhel
2026-02-03 15:01 ` Rob Herring
2026-02-03 15:03 ` Svyatoslav Ryhel
2026-01-25 13:43 ` [PATCH v1 08/10] dt-bindings: mfg: motorola-cpcap: " Svyatoslav Ryhel
2026-01-26 14:37 ` Rob Herring
2026-01-31 20:07 ` David Lechner
2026-02-01 7:09 ` Svyatoslav Ryhel
2026-01-25 13:43 ` [PATCH v1 09/10] mfd: motorola-cpcap: diverge configuration per-board Svyatoslav Ryhel
2026-01-26 10:13 ` Andy Shevchenko
2026-01-26 10:14 ` Svyatoslav Ryhel
2026-01-25 13:43 ` [PATCH v1 10/10] mfd: motorola-cpcap: add support for Mot CPCAP composition Svyatoslav Ryhel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXc9n_gc7TEFvNA8@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andy@kernel.org \
--cc=broonie@kernel.org \
--cc=clamor95@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dixitparmar19@gmail.com \
--cc=dlechner@baylibre.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox