From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70BD13064AF; Mon, 26 Jan 2026 10:10:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769422248; cv=none; b=G0e65kHYcoSiJE8gfuNtGpM3jAupTg/e3HEJXtl5ESnU4ic+yj/5M1jDuD2y5JVg9SFNpu62upX6gwSPGLHWkQvPrwpxw0FgqQJ+IBSZh7m7cSR2pVn3Qfw8e9gQSadXOi1YfeS1NLzrj0XW1okwNBD3HeAUK9WwTwnABVrGQro= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769422248; c=relaxed/simple; bh=Tw1PGm4BgpZd9LnQ5sgcPOcjTd28/XnCmSCwK2lu8Vw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=loztVnPzXo6ZEbD4igoCgp1x12x+ubNTkGGSFoc71/VL/pVskqhlPob47cLlnT6AdNFcwqT2M9INTId7/bOsytzt1kB4L0ZzZyz8OsQXi2FHSi5DaV1X+W76DqjlYBwk2a3ZHppwrTGQi1jOpLCo6iGQktvhqPqlFdtk30u3CRM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Ui9b5nwa; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Ui9b5nwa" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769422247; x=1800958247; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Tw1PGm4BgpZd9LnQ5sgcPOcjTd28/XnCmSCwK2lu8Vw=; b=Ui9b5nwaKcQ8BLx9ZkevT5VfqxA9bowd+uoBxew9PhCHejjCJTclE8mQ xeEkq4+b07weUxWPsnATSEYyikV0hstMEGKGuLC+4k5I2tUqf26kbnI0g RRhhrgjyNyPK0RP55yczHad5v3HKFb8FHtpJKKibGpmAnviAB6SlbXLPy NSChIDWfRLoWpkO1zkg89PS8t9otyVqw48D3pkEwDxqQAkLrbPRsXuMfd U0CFNhg6R72lXTeaUnqy+/+rb6RGRKpqDXDJ7HDVrLa2dPWfBoTza2hk7 uiaJK8yZg8DsYGh62KqSmwp39am4/ylJFtACmWUIzVhwuCxq0tROFkpKE g==; X-CSE-ConnectionGUID: gPl97HbmSOqWn9QTcrvoxQ== X-CSE-MsgGUID: mWkYWzcJTCWOkuBLZo/W+w== X-IronPort-AV: E=McAfee;i="6800,10657,11682"; a="74439458" X-IronPort-AV: E=Sophos;i="6.21,254,1763452800"; d="scan'208";a="74439458" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2026 02:10:46 -0800 X-CSE-ConnectionGUID: PS1MA59iSFafenoqNWnutg== X-CSE-MsgGUID: ASba5ayqQdi7cp9BIj2Fxw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,254,1763452800"; d="scan'208";a="207892624" Received: from smoticic-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.122]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2026 02:10:41 -0800 Date: Mon, 26 Jan 2026 12:10:39 +0200 From: Andy Shevchenko To: Svyatoslav Ryhel Cc: Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Lee Jones , Pavel Machek , Liam Girdwood , Mark Brown , Alexandre Belloni , Dixit Parmar , Tony Lindgren , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v1 02/10] regulator: cpcap-regulator: add support for Mot regulators Message-ID: References: <20260125134302.45958-1-clamor95@gmail.com> <20260125134302.45958-3-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260125134302.45958-3-clamor95@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Sun, Jan 25, 2026 at 03:42:54PM +0200, Svyatoslav Ryhel wrote: > Add support for regulator set used in Motorola Mot board, used as a base > for Atrix 4G and Droid X2 smartphones. ... > +static const unsigned int sw_mot_val_tbl[] = { 600000, 612500, 625000, > + 637500, 650000, 662500, > + 675000, 687500, 700000, > + 712500, 725000, 737500, > + 750000, 762500, 775000, > + 787500, 800000, 812500, > + 825000, 837500, 850000, > + 862500, 875000, 887500, > + 900000, 912500, 925000, > + 937500, 950000, 962500, > + 975000, 987500, 1000000, > + 1012500, 1025000, 1037500, > + 1050000, 1062500, 1075000, > + 1087500, 1100000, 1112500, > + 1125000, 1137500, 1150000, > + 1162500, 1175000, 1187500, > + 1200000, 1212500, 1225000, > + 1237500, 1250000, 1262500, > + 1275000, 1287500, 1300000, > + 1312500, 1325000, 1337500, > + 1350000, 1362500, 1375000, > + 1387500, 1400000, 1412500, > + 1425000, 1437500, 1450000, > + 1462500, 1475000, }; What a style! (Yeah, I see it's being used elsewhere here...) ... > + CPCAP_REG(VAUDIO, CPCAP_REG_VAUDIOC, CPCAP_REG_ASSIGN4, > + CPCAP_BIT_VAUDIO_SEL, vaudio_val_tbl, > + 0x16, 0x1, 0x5, 0, 0), > + { /* sentinel */ }, No trailing comma for sentinel. > +}; -- With Best Regards, Andy Shevchenko