linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Stuart Hayhurst <stuart.a.hayhurst@gmail.com>,
	linux-input@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
	Benjamin Tissoires <bentiss@kernel.org>,
	Jiri Kosina <jikos@kernel.org>
Subject: Re: [PATCH] HID: corsair-void: Add Corsair Void headset family driver
Date: Sun, 18 Aug 2024 15:12:55 +0200	[thread overview]
Message-ID: <aa331200-205e-4b00-ae02-343c96c52ae8@web.de> (raw)
In-Reply-To: <20240813153819.840275-3-stuart.a.hayhurst@gmail.com>

How do you think about to distinguish properties any further for available
device attributes?
https://elixir.bootlin.com/linux/v6.11-rc3/source/Documentation/driver-api/driver-model/device.rst#L38


…
> +++ b/drivers/hid/hid-corsair-void.c
> @@ -0,0 +1,851 @@
…
> +static DEVICE_ATTR(fw_version_receiver, 0444, corsair_void_report_firmware, NULL);
> +static DEVICE_ATTR(fw_version_headset, 0444, corsair_void_report_firmware, NULL);

* Are these really changeable?

* Can the macro “DEVICE_ATTR_RO” be applied?


…
> +MODULE_AUTHOR("Stuart Hayhurst");

Would you like to add an email address here?

Regards,
Markus

  parent reply	other threads:[~2024-08-18 13:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-13 15:38 [PATCH] HID: corsair-void: Add Corsair Void headset family driver Stuart Hayhurst
2024-08-15  4:19 ` kernel test robot
2024-08-15  7:50 ` Markus Elfring
2024-08-16  0:57   ` Stuart
2024-08-16 14:49 ` kernel test robot
2024-08-18 13:12 ` Markus Elfring [this message]
2024-08-18 23:17   ` Stuart
2024-08-19  5:53     ` Markus Elfring
2024-08-19 17:16       ` Stuart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa331200-205e-4b00-ae02-343c96c52ae8@web.de \
    --to=markus.elfring@web.de \
    --cc=bentiss@kernel.org \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stuart.a.hayhurst@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).