From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Xiong Nandi <xndchn@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Gatien Chevallier <gatien.chevallier@foss.st.com>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@kernel.org>,
Marco Crivellari <marco.crivellari@suse.com>,
Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Subject: Re: [PATCH] Input: gpio-keys - add full support of EV_REL and EV_ABS
Date: Sat, 21 Mar 2026 00:06:31 -0700 [thread overview]
Message-ID: <ab5CXO6Fk7lhGazv@google.com> (raw)
In-Reply-To: <20260320145217.9088-1-xndchn@gmail.com>
Hi Xiong,
On Fri, Mar 20, 2026 at 10:52:14PM +0800, Xiong Nandi wrote:
> gpio_keys_gpio_report_event() handled EV_ABS but silently ignored EV_REL,
> while the polled driver supports both. Extend the interrupt-driven driver
> to fire an EV_REL event on button press.
>
> For EV_ABS, use a shared atomic counter per (type, code) pair so that
> a zero-value reset is sent only when the last active button on an axis
> is released, avoiding premature axis resets when multiple buttons share
> the same axis code.
>
> Add gpio_keys_set_abs_params() to call input_set_abs_params() at setup
> time, deriving the axis min/max from the configured button values.
> Without this the input subsystem reports unbounded axis ranges.
Could you please split this out? It looks like there are 2 or 3
logically separate changes.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2026-03-21 7:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 14:52 [PATCH] Input: gpio-keys - add full support of EV_REL and EV_ABS Xiong Nandi
2026-03-21 7:06 ` Dmitry Torokhov [this message]
2026-03-22 11:35 ` [PATCH v2 0/3] " Xiong Nandi
2026-03-22 11:35 ` [PATCH v2 1/3] Input: gpio-keys - set EV_ABS axis parameters at setup time Xiong Nandi
2026-03-22 11:35 ` [PATCH v2 2/3] Input: gpio-keys - use shared axis counter for EV_ABS events Xiong Nandi
2026-03-22 11:35 ` [PATCH v2 3/3] Input: gpio-keys - add EV_REL event type support Xiong Nandi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab5CXO6Fk7lhGazv@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=gatien.chevallier@foss.st.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.crivellari@suse.com \
--cc=mingo@kernel.org \
--cc=tglx@kernel.org \
--cc=xndchn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox