From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: robin@protonic.nl, andy@kernel.org, geert@linux-m68k.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
dmitry.torokhov@gmail.com, hvilleneuve@dimonoff.com,
mkorpershoek@kernel.org, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com, lee@kernel.org,
alexander.sverdlin@gmail.com, marek.vasut@gmail.com,
akurz@blala.de, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v5 4/4] Input: charlieplex_keypad: add GPIO charlieplex keypad
Date: Fri, 13 Mar 2026 11:22:39 +0200 [thread overview]
Message-ID: <abPXX1eWoq7C7J1R@ashevche-desk.local> (raw)
In-Reply-To: <20260312180304.3865850-5-hugo@hugovil.com>
On Thu, Mar 12, 2026 at 02:00:58PM -0400, Hugo Villeneuve wrote:
>
> Add support for GPIO-based charlieplex keypad, allowing to control
> N^2-N keys using N GPIO lines.
>
> Reuse matrix keypad keymap to simplify, even if there is no concept
> of rows and columns in this type of keyboard.
LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-13 9:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 18:00 [PATCH v5 0/4] input: add GPIO-based charlieplex keypad Hugo Villeneuve
2026-03-12 18:00 ` [PATCH v5 1/4] dt-bindings: input: add debounce-delay-ms common property Hugo Villeneuve
2026-03-12 18:00 ` [PATCH v5 2/4] dt-bindings: input: add settling-time-us " Hugo Villeneuve
2026-03-12 18:00 ` [PATCH v5 3/4] dt-bindings: input: add GPIO charlieplex keypad Hugo Villeneuve
2026-03-12 18:00 ` [PATCH v5 4/4] Input: charlieplex_keypad: " Hugo Villeneuve
2026-03-13 9:22 ` Andy Shevchenko [this message]
2026-03-13 9:21 ` [PATCH v5 0/4] input: add GPIO-based " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abPXX1eWoq7C7J1R@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=akurz@blala.de \
--cc=alexander.sverdlin@gmail.com \
--cc=andy@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=geert@linux-m68k.org \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=mkorpershoek@kernel.org \
--cc=robh@kernel.org \
--cc=robin@protonic.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox