Re: [PATCH V3]: HID: asus: add support for ASUS N-Key keyboard

[Luke Jones <luke@ljones.dev>]

On Tue, 2020-08-04 at 10:17 +0200, Silvan Jegen wrote:
> Hi
> 
> Luke Jones <luke@ljones.dev> wrote:
> > [snip...] 
> > 
> > +/*
> > + * This enables triggering events in asus-wmi
> > + */
> > +static int asus_wmi_send_event(struct asus_drvdata *drvdat, u8
> > code)
> > +{
> > + int err;
> > + u32 retval;
> > +
> > + err = asus_wmi_evaluate_method(ASUS_WMI_METHODID_DEVS,
> > + ASUS_WMI_METHODID_NOTIF, code, &retval);
> > + if (err) {
> > + pr_warn("Failed to notify asus-wmi: %d\n", err);
> > + return err;
> > + }
> 
> It looks like your MUA removed all indentation tabs from your patch.
> IIRC,
> the gmail web interface has been accused of this before...
> 
> Most likely this will have to be fixed before someone approves of
> this patch.
> 
> 
> Cheers,
> 
> Silvan
> 
> 
> > [...]

Thank you for the heads up. Turns out Geary, although a nice email
client in general, is not suitable for this type of task.

Cheers,
Luke