Re: [PATCH] Haptic class support (v2)

[Kay Sievers <kay.sievers@vrfy.org>]

On Tue, Oct 6, 2009 at 09:45, Kyungmin Park <kmpark@infradead.org> wrote:
> This patch includes two haptic devices, isa1000 and isa1200
> ISA1000 is gpio based haptic, but isa1200 is based on I2C
> Both are working on Samsung SoCs and tested.
>
> To enable the haptic, echo 1 > /sys/class/haptic/${name}/enable
> You can adjust the level by echo ${level} > /sys/class/haptic/${name}/enable
> or
> With oneshot feature, echo ${msec time} > /sys/class/haptic/${name}/oneshot

Please never add any custom files to the top-level of a class
directory. This place is reserved for devices, and not for custom
files. It's a serious bug in the layout and API of sysfs that this
allowed at all.

If you need these subsystem-wide contols please use a bus and not a
class to stuff these files into a place where they don't mix up with
the list of devices belonging to a class. Buses have all devices in a
devices/ subdir so they will not conflict.

Thanks,
Kay