Re: [PATCH] HID: cherry: Fix switch case formatting

[Benjamin Tissoires <bentiss@kernel.org>]

On Mar 25 2026, aravindanilraj0702@gmail.com wrote:
> From: Aravind Anilraj <aravindanilraj0702@gmail.com>
> 
> Fix checkpatch warnings by splitting single-line case
> statements into multiple lines.
> 
> No functional changes.
> 
> Signed-off-by: Aravind Anilraj <aravindanilraj0702@gmail.com>
> ---
>  drivers/hid/hid-cherry.c | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/hid/hid-cherry.c b/drivers/hid/hid-cherry.c
> index a504632febfc..828a3cc67512 100644
> --- a/drivers/hid/hid-cherry.c
> +++ b/drivers/hid/hid-cherry.c
> @@ -43,9 +43,15 @@ static int ch_input_mapping(struct hid_device *hdev, struct hid_input *hi,
>  		return 0;
>  
>  	switch (usage->hid & HID_USAGE) {
> -	case 0x301: ch_map_key_clear(KEY_PROG1);	break;
> -	case 0x302: ch_map_key_clear(KEY_PROG2);	break;
> -	case 0x303: ch_map_key_clear(KEY_PROG3);	break;
> +	case 0x301:
> +		ch_map_key_clear(KEY_PROG1);
> +		break;
> +	case 0x302:
> +		ch_map_key_clear(KEY_PROG2);
> +		break;
> +	case 0x303:
> +		ch_map_key_clear(KEY_PROG3);
> +		break;

Nack: please don't run checkpatch on existing and already merged code.

This comment is valid for all the other similar patches you sent today.

There are many reasons to refuse such a patch, but mostly it's just
pointless and makes looking into the history harder.

If you fix something in the code, then yes, you can also make formatting
fixes, but formatting for just fomratting is going to be rejected in all
subsystems you attempt to contribute to.

Cheers,
Benjamin

>  	default:
>  		return 0;
>  	}
> -- 
> 2.47.3
> 
>