Re: [PATCH v2 2/8] dt-bindings: input: touchscreen: document synaptics TCM oncell

[Krzysztof Kozlowski <krzk@kernel.org>]

On 30/06/2024 20:36, Caleb Connolly wrote:
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/syna,tcm-oncell.yaml b/Documentation/devicetree/bindings/input/touchscreen/syna,tcm-oncell.yaml
> new file mode 100644
> index 000000000000..6e366c9446f8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/syna,tcm-oncell.yaml

Filename like compatible, so syna,s3908.yaml

> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/touchscreen/syna,tcm-oncell.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Synaptics TCM Oncell i2c touchscreen
> +
> +maintainers:
> +  - Caleb Connolly <caleb@postmarketos.org>
> +
> +allOf:
> +  - $ref: touchscreen.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - syna,s3908
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts-extended:

Instead, just interrupts:

> +    maxItems: 1
> +
> +  reset-gpios:
> +    maxItems: 1
> +    description: Reset GPIO the chip is connected to.
> +
> +  vdd-supply:
> +    description: a phandle for the regulator supplying 3V power.
> +
> +  vcc-supply:
> +    description: a phandle for the regulator supplying IO power.
> +
> +additionalProperties: false

This goes after "required:" block.

> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts-extended
> +  - reset-gpios
> +  - vdd-supply
> +  - vcc-supply
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +      clock-frequency = <400000>;

Drop

> +      status = "okay";

Drop

> +
> +      touchscreen@4b {
> +        compatible = "syna,s3908";
> +        reg = <0x4B>;
> +
> +        interrupts-extended = <&tlmm 39 0x2008>;

Not a correct interrupt flag, I think.

Best regards,
Krzysztof