From: Aaro Koskinen <aaro.koskinen@iki.fi>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
Janusz Krzysztofik <jmkrzyszt@gmail.com>,
Tony Lindgren <tony@atomide.com>,
Linus Walleij <linusw@kernel.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v2 2/2] Input: ads7846 - fix up the pendown GPIO setup on Nokia 770
Date: Mon, 20 Apr 2026 22:43:08 +0300 [thread overview]
Message-ID: <aeaBzPwdkwJzjFD8@darkstar.musicnaut.iki.fi> (raw)
In-Reply-To: <aeVs2VUqPL1v0Vka@google.com>
Hi,
On Sun, Apr 19, 2026 at 05:06:53PM -0700, Dmitry Torokhov wrote:
> > - d = gpiod_get(NULL, "ads7846_irq", GPIOD_IN);
> > - if (IS_ERR(d))
> > - pr_err("Unable to get ADS7846 IRQ GPIO descriptor\n");
> > - else
> > - nokia770_spi_board_info[1].irq = gpiod_to_irq(d);
>
> No, I think what we need here is a simple gpiod_put(). The mapping is
> not going to change unless someone tries to unload gpiochip, but then
> the device is not going to work anyway.
OK, I will do that in v3. I tried unbind/re-bind the gpiochip before
loading the touchscreen module and yes, it seems to fail in consistent
manner without suprises (e.g. no crash, just probe failing).
A.
next prev parent reply other threads:[~2026-04-20 19:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-19 16:18 [PATCH v2 0/2] Input/omap1: fix touchscreen functionality on Nokia 770 Aaro Koskinen
2026-04-19 16:18 ` [PATCH v2 1/2] Input: ads7846 - restore half-duplex support Aaro Koskinen
2026-04-20 0:13 ` Dmitry Torokhov
2026-04-20 19:32 ` Aaro Koskinen
2026-04-19 16:18 ` [PATCH v2 2/2] Input: ads7846 - fix up the pendown GPIO setup on Nokia 770 Aaro Koskinen
2026-04-20 0:06 ` Dmitry Torokhov
2026-04-20 19:43 ` Aaro Koskinen [this message]
2026-04-19 20:10 ` [PATCH v2 0/2] Input/omap1: fix touchscreen functionality " Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeaBzPwdkwJzjFD8@darkstar.musicnaut.iki.fi \
--to=aaro.koskinen@iki.fi \
--cc=dmitry.torokhov@gmail.com \
--cc=jmkrzyszt@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox