Re: [PATCH] input: add suspend wakeup support to sh_keysc

[Magnus Damm <magnus.damm@gmail.com>]

Hi Trilok,

Thanks for your comments!

On Tue, Mar 10, 2009 at 5:24 PM, Trilok Soni <soni.trilok@gmail.com> wrote:
> Hi Magnus,
>
>> +
>> +       device_init_wakeup(&pdev->dev, 1);
>>        return 0;
>
>
> Please add device_init_wakeup(&pdev->dev, 0) in sh_keysc_remove.

Isn't this just flagging the device as wakeup capable? My first guess
would be that the the wakeup state of a removed device is irrelevant
since it won't be suspended anyway. Or am I misunderstanding? Please
explain in more detail.

>>  err5:
>>        free_irq(irq, pdev);
>> @@ -253,17 +255,36 @@ static int __devexit sh_keysc_remove(str
>>        return 0;
>>  }
>>
>> +static int sh_keysc_suspend(struct device *dev)
>> +{
>> +       struct platform_device *pdev;
>> +       struct sh_keysc_priv *priv;
>> +       unsigned short value;
>> +
>> +       pdev = container_of(dev, struct platform_device, dev);
>> +       priv = platform_get_drvdata(pdev);
>
> to_platform_device(...) ?

Thanks, much better!

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html