From: Magnus Damm <magnus.damm@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, lethal@linux-sh.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH] input: bitmap update for sh_keysc V2
Date: Wed, 10 Feb 2010 13:13:37 +0900 [thread overview]
Message-ID: <aec7e5c31002092013y615cb624x78a9d5fad126b3ec@mail.gmail.com> (raw)
In-Reply-To: <20100209093954.GC12642@core.coreip.homeip.net>
On Tue, Feb 9, 2010 at 6:39 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Tue, Feb 09, 2010 at 06:16:09PM +0900, Magnus Damm wrote:
>> From: Magnus Damm <damm@opensource.se>
>>
>> Update the sh_keysc driver with proper bitmap support V2.
>> This instead of using a fixed 32-bit integer to keep track
>> for the key states. With this change in place the driver
>> supports key pads with more than 32 keys.
>>
>> Signed-off-by: Magnus Damm <damm@opensource.se>
>> ---
>>
>> Changes since V1:
>> - ditched the wrapping macros
>> - use __set_bit() and __clear_bit()
>
> Thank you for making the change. It indeed is easier to read than the
> original since one does not have to go and look up what wrappers are
> doing.
Yeah, I initially disliked the SH_KEYSC_MAXKEYS that now are sprinkled
all over the place, but I have to admit that not using wrappers made
me realize that I should use __set_bit() and __clear_bit() instead of
the atomic ones. So all good.
Thanks!
/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-02-10 4:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-09 9:16 [PATCH] input: bitmap update for sh_keysc V2 Magnus Damm
2010-02-09 9:39 ` Dmitry Torokhov
2010-02-10 4:13 ` Magnus Damm [this message]
2010-02-10 9:26 ` Dmitry Torokhov
2010-02-10 11:13 ` Magnus Damm
2010-02-10 17:59 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aec7e5c31002092013y615cb624x78a9d5fad126b3ec@mail.gmail.com \
--to=magnus.damm@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).