From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Natália Salvino André" <natalia.andre@ime.usp.br>
Cc: andy@kernel.org, bentiss@kernel.org, dlechner@baylibre.com,
jic23@kernel.org, jikos@kernel.org, nuno.sa@analog.com,
srinivas.pandruvada@linux.intel.com,
Pietro Di Consolo Gregorio <pietro.gregorio@usp.br>,
linux-iio@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH v2 2/7] iio: accel: HID: Replace method accel_3d_adjust_channel_bit_mask()
Date: Wed, 22 Apr 2026 12:07:07 +0300 [thread overview]
Message-ID: <aeiPuxj2TRLNRbv1@ashevche-desk.local> (raw)
In-Reply-To: <20260421222210.16016-3-natalia.andre@ime.usp.br>
On Tue, Apr 21, 2026 at 07:20:34PM -0300, Natália Salvino André wrote:
> Replace method accel_3d_adjust_channel_bit_mask()
> with helper method hid_sensor_adjust_channel_bit_mask().
...
> - accel_3d_adjust_channel_bit_mask(channels,
> - CHANNEL_SCAN_INDEX_X + i,
> - st->accel[CHANNEL_SCAN_INDEX_X + i].size);
> + hid_sensor_adjust_channel_bit_mask(channels,
> + CHANNEL_SCAN_INDEX_X + i,
> + st->accel[CHANNEL_SCAN_INDEX_X + i].size);
Indentation is broken. Taking into account that the last line is too long when
properly indented, perhaps
hid_sensor_adjust_channel_bit_mask(channels,
CHANNEL_SCAN_INDEX_X + i,
st->accel[CHANNEL_SCAN_INDEX_X + i].size);
Which makes it most right and under 80 limit.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-22 9:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 22:20 [PATCH v2 0/7] Add helper method hid_sensor_adjust_channel_bit_mask() Natália Salvino André
2026-04-21 22:20 ` [PATCH v2 1/7] iio: HID: " Natália Salvino André
2026-04-22 9:03 ` Andy Shevchenko
2026-04-21 22:20 ` [PATCH v2 2/7] iio: accel: HID: Replace method accel_3d_adjust_channel_bit_mask() Natália Salvino André
2026-04-22 9:07 ` Andy Shevchenko [this message]
2026-04-21 22:20 ` [PATCH v2 3/7] iio: gyro: HID: Replace method gyro_3d_adjust_channel_bit_mask() Natália Salvino André
2026-04-22 9:14 ` Andy Shevchenko
2026-04-21 22:20 ` [PATCH v2 4/7] iio: light: HID: Replace method als_adjust_channel_bit_mask() Natália Salvino André
2026-04-22 9:17 ` Andy Shevchenko
2026-04-21 22:20 ` [PATCH v2 5/7] iio: light: HID: Replace method prox_adjust_channel_bit_mask() Natália Salvino André
2026-04-22 9:16 ` Andy Shevchenko
2026-04-21 22:20 ` [PATCH v2 6/7] iio: magnetometer: HID: Replace method magn_3d_adjust_channel_bit_mask() Natália Salvino André
2026-04-22 9:18 ` Andy Shevchenko
2026-04-21 22:20 ` [PATCH v2 7/7] iio: pressure: HID: Replace method press_adjust_channel_bit_mask() Natália Salvino André
2026-04-22 9:18 ` Andy Shevchenko
2026-04-22 9:21 ` [PATCH v2 0/7] Add helper method hid_sensor_adjust_channel_bit_mask() Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeiPuxj2TRLNRbv1@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=bentiss@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=natalia.andre@ime.usp.br \
--cc=nuno.sa@analog.com \
--cc=pietro.gregorio@usp.br \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox