From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f182.google.com (mail-dy1-f182.google.com [74.125.82.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BEBF3E1CF6 for ; Fri, 8 May 2026 13:57:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778248671; cv=none; b=ulHCeHVK/RQPy0qWJCGZRU1wgAbqrGWCpk9FSTeyf3PZaPeT/VHYRjV4bmtqomm9Dn0lhDvhtuKmOKFG96rB0NF8N62mngI4jSKK54j50SNI5AElRUT3g/elgp6/6Ve+iASRrO3rjZKBNaobW5K3gLqBopqg3Mhdl562TVTSC0A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778248671; c=relaxed/simple; bh=jm8S5eHYmLUlHSlinkOSY2lIF9Dc6wGjPC5ZNBOT+BY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BueOhlREa5MFD2a5e07gMyzcusN5GfB2fhYuaYNNkOUv2lTgKsFqtvUybDfyMse5VkkiZ/ljnj9lwl7POUKxO4j4LXBFwooQ2F1pkG/ue/PoDhD5duriW/STBBRLUOv9PfXe7isiaF276TqyCas0/zh+kFm9EZApDCwCblghr7o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Uwsyz8xS; arc=none smtp.client-ip=74.125.82.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Uwsyz8xS" Received: by mail-dy1-f182.google.com with SMTP id 5a478bee46e88-2c15849aa2cso2586769eec.0 for ; Fri, 08 May 2026 06:57:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778248668; x=1778853468; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=mvH1zlruzUaAUBZaKhp6+2gmZc2N+rNmWQijZPZfi+c=; b=Uwsyz8xSnuoHXlg5P3pv6e6TNKsUnvCu5TH3gtDL14Z+d0B058+EUjF1kns/KNL56l VFpauuGZH+BXuFnd+hN/Uhx1vhd1+gPl9TKajmGaX3XEmCrAwHxJ536tjZKcFYfVut6V yGXhAAfAYeeyRSUjLDSwBjxTkX+kOpUFxcxXY/e43Y43AKNpKaJv2td/AmryDfHfSKfm l/h5WeKu2TeCDDE5trhESIwWVAucN5TZalWACU2YXhT2KLU6DITEA1XXC4Ug9I9pvVum 1OujkT6fHmJGNwd2TE+kannqAzOEHRnvH0Lb+yL9XnSDcv5ve8IFQPZqK9FnTLWr0k0x cDwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778248668; x=1778853468; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mvH1zlruzUaAUBZaKhp6+2gmZc2N+rNmWQijZPZfi+c=; b=ZtpMgNyjgFcuPOyIFdnM9AsjkjNr2WXKXfQ2p1R3a794Gd6aLCruQaXQT5YRfuK4fp 9JjAsUD7s3dplhDpOkBi7CPhpF7JxjabQWqZHd6FTaxBG9Rl9AIzyNLMVytz8zXCtNWx /sPdlM0kOLi/hwQP4UfooSa7fnCPt8l2Um8RHaBwBdcSs2XxQe9xFvyyHiuGNNJElo4T uigYUdkq4JFV9+JOn8DANWSjZ9/3N5iFBCZiNtXaETuo0dI1aGoBaGk1RR3dczkwD5lt Ba/bKYkZyuoz2KYEolOoQBgn2lQmixvAlwC37b6vgb28jtbWljKA5mbXL8kBiYpUmcNa Mljw== X-Forwarded-Encrypted: i=1; AFNElJ90HPgJgeTnK5Kp2wX2dlFjt+4sdgD2WjjRWKmqy7b/KM058PXrmuS/rIgRk7dmg2j9jhbYOMddthZs4Q==@vger.kernel.org X-Gm-Message-State: AOJu0YwCkPBCrxBbE0x9uvuCYKUZiXz3fqSXNqPdvPpkHmpUuLoS4CoT 06urUqYCSbbF+jZGKqBab1i2L8eJazV9Lu9KFyc+Tq45kkBP2zhtD986 X-Gm-Gg: Acq92OGStybAmV+e4H1bWQUadLeVdT6h8Kyaz+js6iQFY5rdpELodqmRE/JCEGslSZA ZTnLXLlpRjTa8hO2RIeJek4G4MhnanwHRaxyxpHRCvZwV58Ru7gWyjHaWpNTxnN5sGxfYoKLO31 a44OVciL9Ntq84enhVoblrub4stDn6I53ZU9a9mraPd8DA7U6snkZ8TEB+IOxQfhMyHi/z/UnPu f9bPWAL9zkSJDiBRUk7r6pndwmFz7AAGLQSS9GixuGbJEq0zrX0mKomXSQlxYHUAMM/jKItRP3f aJpm5UKCZec1/Wf1LkvlituACsHXrgvL0OhAKn8sRWno8n9xtvz0cCokGwxwLQLr0uCtjX1fS0M 4nDw03MZrYdDWOSedxbA6HoIJ6wOXpLQ6Neg654VpM+UjxWQ5ASsNftfssQ9wzrqXxzLNKHzf02 aFyVz8ozuTUe+cAYlh7Cm14hSIeHQm0GY62uht1OadhkGfD/rkCKj9Si/E45uTc4twijKlKgKwN 5g= X-Received: by 2002:a05:7300:ec08:b0:2ea:c085:44b1 with SMTP id 5a478bee46e88-2f549f838d8mr5657827eec.19.1778248668002; Fri, 08 May 2026 06:57:48 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:852e:ebf3:8de1:32e1]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f88847502fsm2577588eec.14.2026.05.08.06.57.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 06:57:47 -0700 (PDT) Date: Fri, 8 May 2026 06:57:44 -0700 From: Dmitry Torokhov To: Svyatoslav Ryhel Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] Input: isa1200 - new driver for Imagis ISA1200 Message-ID: References: <20260507133948.75704-1-clamor95@gmail.com> <20260507133948.75704-3-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, May 08, 2026 at 02:13:43PM +0300, Svyatoslav Ryhel wrote: > чт, 7 трав. 2026 р. о 22:26 Dmitry Torokhov пише: > > > > Hi Svyatoslav, > > > > On Thu, May 07, 2026 at 04:39:48PM +0300, Svyatoslav Ryhel wrote: ... > > > +} > > > + > > > +static int isa1200_suspend(struct device *dev) > > > +{ > > > + struct isa1200 *isa = dev_get_drvdata(dev); > > > + > > > + cancel_work_sync(&isa->play_work); > > > > Move it under input_device_enabled(). > > > > > + > > > + guard(mutex)(&isa->input->mutex); > > > + > > Should I remove mutex locking from both PM functions? No, you should remove it from isa1200_play_work(). Thanks. -- Dmitry