From: Benjamin Tissoires <bentiss@kernel.org>
To: James Clark <james.clark@linaro.org>
Cc: Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Jiri Kosina <jikos@kernel.org>, Shuah Khan <shuah@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@linux.dev>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
ihor.solodrai@linux.dev, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, linux-input@vger.kernel.org,
linux-kselftest@vger.kernel.org, bpf@vger.kernel.org,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2 3/6] selftests: Remove unused LLD variable
Date: Thu, 21 May 2026 17:30:32 +0200 [thread overview]
Message-ID: <ag8k4k6f_dlchcuA@beelink> (raw)
In-Reply-To: <20260518-james-perf-llvm-version-v2-3-f12cc4f031d8@linaro.org>
On May 18 2026, James Clark wrote:
> This file was mostly copied from selftests/bpf/Makefile, but the LLD
> variable is not used here. Also, this copied block didn't get the same
> fixes as the original one did later.
>
> Remove it to avoid confusion and so future fixes don't have to be in two
> places.
>
> Signed-off-by: James Clark <james.clark@linaro.org>
> ---
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git (for-7.2/bpf), thanks!
[3/6] selftests: Remove unused LLD variable
https://git.kernel.org/hid/hid/c/08918b98b02b
Cheers,
Benjamin
> tools/testing/selftests/hid/Makefile | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/tools/testing/selftests/hid/Makefile b/tools/testing/selftests/hid/Makefile
> index 50ec9e0406ab..96071b4800e8 100644
> --- a/tools/testing/selftests/hid/Makefile
> +++ b/tools/testing/selftests/hid/Makefile
> @@ -105,13 +105,6 @@ $(MAKE_DIRS):
> $(call msg,MKDIR,,$@)
> $(Q)mkdir -p $@
>
> -# LLVM's ld.lld doesn't support all the architectures, so use it only on x86
> -ifeq ($(SRCARCH),x86)
> -LLD := lld
> -else
> -LLD := ld
> -endif
> -
> DEFAULT_BPFTOOL := $(HOST_SCRATCH_DIR)/sbin/bpftool
>
> TEST_GEN_PROGS_EXTENDED += $(DEFAULT_BPFTOOL)
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2026-05-21 15:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 9:03 [PATCH v2 0/6] tools/build: Allow versioning of all LLVM tools James Clark
2026-05-18 9:03 ` [PATCH v2 1/6] tools/build: Allow versioning of all LLVM tools defined in Makefile.include James Clark
2026-05-18 9:03 ` [PATCH v2 2/6] tools/build: Indent if else blocks James Clark
2026-05-18 9:03 ` [PATCH v2 3/6] selftests: Remove unused LLD variable James Clark
2026-05-21 15:30 ` Benjamin Tissoires [this message]
2026-05-18 9:03 ` [PATCH v2 4/6] tools/build: Allow versioning LLVM readelf James Clark
2026-05-18 16:05 ` Ian Rogers
2026-05-18 9:03 ` [PATCH v2 5/6] tools/build: selftests: Allow versioning LLVM lld James Clark
2026-05-18 9:32 ` sashiko-bot
2026-05-18 9:47 ` James Clark
2026-05-20 19:50 ` Arnaldo Carvalho de Melo
2026-05-21 13:16 ` James Clark
2026-05-18 9:03 ` [PATCH v2 6/6] tools/build: selftests: Remove some duplicate toolchain definitions James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ag8k4k6f_dlchcuA@beelink \
--to=bentiss@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=ihor.solodrai@linux.dev \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jikos@kernel.org \
--cc=jolsa@kernel.org \
--cc=justinstitt@google.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=namhyung@kernel.org \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox