From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f181.google.com (mail-dy1-f181.google.com [74.125.82.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A9A73C5853 for ; Wed, 27 May 2026 21:56:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779918967; cv=none; b=qAjypBH2X7ckhXLbb19BY4Qof/Q1AlZ/CcZ/BwLFFpdDxZyNAS0cgo7VUFj74uHw7lpb6VkbRiPV6Zl0iWaJ5AjZCfI2WtmJpxRCotwTHZIHEzYOdbyNbzVgqNLmlsOOhNovBUle7CJtKdSSQPVSdHoiteC4iz9YGTNTsArTPmg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779918967; c=relaxed/simple; bh=cGKtD3QmWzMTCMfMKYNFa7orYz8sE6eXPChDz4N75IY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qSrIUmwTP2vxvC+jzyj6d/9MRM/BxEhLSKWcmK77lrwOdMGumriB8xwvDA4/JvTrzMuYJ3MeUg1L+QnQGUdrpF7FfvRBlDNlNwYbQCus1QXE2dvGRC4CibdmWmpPgdzvUdjFUhcN+oaTaIpDT8b3YojBbYu0HN7SRUSs2wTAcxY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kDHCWD97; arc=none smtp.client-ip=74.125.82.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kDHCWD97" Received: by mail-dy1-f181.google.com with SMTP id 5a478bee46e88-304545f5206so8224548eec.0 for ; Wed, 27 May 2026 14:56:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779918965; x=1780523765; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lXg+VJDmtN8gtR2tAPqmElloUoo693bty2sHUHo0J88=; b=kDHCWD97AFaM0TwG/LKKBFvGv8ZfsoJby8ur46cvwPMS2jOwKjW3mit0bDkFamtB/N qTyCVW+41DzBsXjUyRANmyhLGdxJzh2I1Z+MGEFsNw79DKMHsQZVPa1D090SQEXeOgkQ JFisuGkFjYzHcU2wqaVcSyhJG/RoYdNCCZGggvrzSfgXA+OYpJNgGE8Ncwq5pHZlZWff ksCY2j/u9nF3GgXcVFnev8mbCMIjmu8oIJfmy3anyjfqWsbGAkF9oaz4S/aJFLZFwzav +I3cV69WwqlXLqcXRl543IW+3EKnCeU8KQHjblU52eSjjLWcmwawOgHpS63DIM+Qi9Ns iANg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779918965; x=1780523765; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lXg+VJDmtN8gtR2tAPqmElloUoo693bty2sHUHo0J88=; b=QCLZXWz5EbZJ3AEGeS1L/h9W7CIQvfU+bf5p/KkBGUY7cAjFuHaOhrhi3NygQuBW/C duAt5kCZqkDh1YuVVoqUj9ud+sJcb9RyF6a2Dgu3ApoZWkuWy55Nj3XcvKC5uDxcnwYT X1EMjvf7mxpAuFPkmKaePFlzZm8GcjvmmWO4ikEwh/uaaRMQ7ag9fngJIG25OieFJDIe b/MBhgkhPzuntDXqd0vDwlC8wIpBpgDAGJ8eSQk1Vbn1LsisQ7EhWTxTgclmyUk94Dg5 CkG1KUATpiVlCy1i+hZ0VYAP3umRzE1pk9+pgh/Avf3GW3H8A0Oz5CqGEE+egJcUyIBP sW8A== X-Forwarded-Encrypted: i=1; AFNElJ/irhEvZQmNdRJdxo1uFaaK3vC2HSOIpooZMgxNV3DIE8nJmmMXtpLIxUYAh2dlcx+Cdri3OED2cIbFMA==@vger.kernel.org X-Gm-Message-State: AOJu0Yx3D9UuIuQu+1Tw092PzTvLLEdc9cFCgj99U7TxDQP9ptaG1bhF k5n7y7+u2we+SC8W5+yfaZ3r0MPWdF+3U22mElfXszZssuS6ZSVqQfjpUaf6Hw== X-Gm-Gg: Acq92OEpOewee3PPz5y9eseWsIDZLe149eujCZHTS31Kc7g2dtpU7NuL3/x+xn3bmGy 9lqc4Z8XBQCxyompyFpxWDHJMNcdlTNVJtDAmeJdmiB3JOtF6irv+c2OeOkXFX9jejXXoOYKMlz w8A9vJzA+Gxnb4mVTRUmNNvuLYb536qfnnKIv42QrMwzTij2alztL7JrOCPIXOBvROdEp6bjgW6 MYm09BFAQkW9JcDnboRQ1H5F9M8NxQCK9hiTrb8m+ZlBF13FueP7s0IAU1nvM1yt+y46w4Y4Oic ujTRn8LKHdYoXxf2hI26NF2dbwFeaAvPwrs4wCueZ8H6tQx44hFai7RZmSrCJ+473By8Sb2Uaev 7cJpCvnVnw/SBgIvjJtuIED0EzixEfEA8v+pv6/p5g8mlw5q/wSidAOyOUdb6XOwTgK5yevh0t5 QwW3UjyIu5mVoiH0BmabzIrXD0oR7/bE9MNLxIRDgJ16Rkhv1bzqvN/qhIWCnZ1Sd+ZlxUka8Wx lQ= X-Received: by 2002:a05:7300:b507:b0:2da:a813:a5fd with SMTP id 5a478bee46e88-30449103797mr11617618eec.22.1779918964504; Wed, 27 May 2026 14:56:04 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:ca8d:7a6a:7fd3:5948]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3045245f4e5sm14357429eec.28.2026.05.27.14.56.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 14:56:03 -0700 (PDT) Date: Wed, 27 May 2026 14:56:00 -0700 From: Dmitry Torokhov To: david@ixit.cz Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Jason A. Donenfeld" , Matthias Schiffer , Vincent Huang , Bjorn Andersson , Konrad Dybcio , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: sdm845-oneplus: Update compatible to include model Message-ID: References: <20260523-synaptics-rmi4-dt-v2-0-0645122babdc@ixit.cz> <20260523-synaptics-rmi4-dt-v2-2-0645122babdc@ixit.cz> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260523-synaptics-rmi4-dt-v2-2-0645122babdc@ixit.cz> Hi David, On Sat, May 23, 2026 at 11:45:35AM +0200, David Heidelberg via B4 Relay wrote: > From: David Heidelberg > > We know the driver is reporting s3706b, introduce the compatible so we > can more easily introduce quirks for weird touchscreen replacements in > followup series. > > Reviewed-by: Konrad Dybcio > Signed-off-by: David Heidelberg > --- > arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi > index 6b7378cf4d493..148164d456a5a 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi > @@ -475,17 +475,17 @@ bq27441_fg: bq27441-battery@55 { > }; > }; > > &i2c12 { > status = "okay"; > clock-frequency = <400000>; > > synaptics-rmi4-i2c@20 { > - compatible = "syna,rmi4-i2c"; > + compatible = "syna,rmi4-s3706b", "syna,rmi4-i2c"; So I believe we established that this device (s3706b) does not in fact implement rmi4 protocol properly. Why do we have "syna,rmi4-i2c" as a fallback? Shouldn't it be just "syna,rmi4-s3706b"? Thanks. -- Dmitry