From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f174.google.com (mail-dy1-f174.google.com [74.125.82.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DD1726FD93 for ; Sun, 31 May 2026 05:13:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780204434; cv=none; b=Yf1BIq84ETBA4mooqLJFKOJPJbPIv6+P/UNmvrE8NrJy94GZ5nDxGlPjsO/2oo5/hVK43CE02dZyWm+cMVwpXv5VsNR4SjlSYf2lFuS2Y1pll40hwXKiQZ4195FieXjlwVxFB1UDUx9f8qTkhGW2WTcihtv4j4mnWsTV8P5Dc5w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780204434; c=relaxed/simple; bh=LvCvl6PBBF8J/xKaNGS0MEYSeqnN/0taZuq8w2G+Az0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VkC4jGGn+T4CoodPDo+PGA6KHM6lj5PF6xc/qvwox19/eK+8LEpv1cYY8oaczilDp66zXTmoCc1GG3z6QNwBRLB2n+D8wIh8qG0cgg0iznFnDwSoQvV10qCIpTY0enHHNicBeuZwjmCgjft5OjrRJmGI78rJyrttBqdnJMUPrUo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FGVCvhaL; arc=none smtp.client-ip=74.125.82.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FGVCvhaL" Received: by mail-dy1-f174.google.com with SMTP id 5a478bee46e88-304b8ced372so6479685eec.0 for ; Sat, 30 May 2026 22:13:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780204433; x=1780809233; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=k3pn4cuUfFSRyvhCaBTSBtnyydB0uD7dBx1ds5nx5l4=; b=FGVCvhaL9eJqxsOcwkywanUWKqdXcMdyFHMj998ZD5zTv7pAGwtECxT+15k1a6qGNq 3qGWi/qCCHRa4tzW+7q246Dl3Rc3IKWfjiaAB8yPCpKVKCOTEmwmTwDvci4G7ZMKU2x1 yG6YxMRjIGesqokaQ0SBjE7YAdhiM4n7MYALHqVcFyjsHSsmnh6+7Dlt3xwFlj93Yc1x JRLZzapmJ63bdcEBep0FR+nWIlAIh6P8mJVKMatOp5VzhdFaI5PY5rXXiaO/n4qmOBhm ZLz5mHTCmWc1xet3BIMF8Mk7nxY5WJPKPOW1f816jdmevSbPyZrhNzvMepdJqd0H9AGc nFmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780204433; x=1780809233; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=k3pn4cuUfFSRyvhCaBTSBtnyydB0uD7dBx1ds5nx5l4=; b=VQt/mzsVC3GU8j/dLEkXD/lOSbLbDzQtE/alAtrx1DdMPUGi3sVSbhmK8Ml1XeqeFG TgCMkSGr7CjW6RN2HylUUh2uJfoTydTdNMWVN1AeBKYMnkMMPq+64p2D/ETEQcBHdOaF PHFfTx65zAkTw/aScHp/UzYcStdSrGRgeezb2CLXxlSmKg1+Q1rQq+QRMKuWHGEqSLvW 8Mg5kLHLLuLi7Xdxvkvs8IIecRmzRsWsAqdyKA46iPdKLL3efePQl2McH+GKZ6lStGgg lDkIrFNF4Ibr0Cz3HZYdvV1AmpJiFvcUy28CnQSvR8OHE7Nvcv8BsBT9eg/j6fvWuBfi M7AQ== X-Forwarded-Encrypted: i=1; AFNElJ/J6hUqbfp8vJHOSbpRu4NxP5pv7PmCbPMEhdIePlaU3yY+PiIeQB8wFhrfGzXL+cSSS3OtbehC5GnBuA==@vger.kernel.org X-Gm-Message-State: AOJu0Yx6eKXkWkN++6YdUspIvHcHepjzLQX35mL8pRVR1VLBedOoXNRx I/FwtTvDF54RKq3e9MzzsBVFxKajWERO9t3G99lMCzEfEYJ+EHmz5do0 X-Gm-Gg: Acq92OFbjESGH+RSHBM1v/Xf6S+Ow779sLpfUaI8GGwJ2BkDeeQ67fsyd1xaq1zF1nN 2TGMyH9doPhHqj0D/bs6cjUC0A8rXWmjJ2UBk+dZ2vRVbh25vtLiYhV5/8RYR5D2GIRVlefSMvt MA62FGyJv0CDOasKsIhmPV6Sn8uCVlwS+6wmzDymiJMkIbJsaFpUeyH5eHz5IbyuGgFL6MeaNxD alwrZo/+LX6S8uHBJSXl8UExp2ypB6GMDIHVbkuGDxeS0MkhXPmNcitjl9zXPCRV24un4g9Ca6b i4m40J50I0mS4mOSKL6CDNv0bkKdwMhz9j7MtMGq5YSObpvP4PWgErgEsLzs+IUngM6GJBRPKsh c1kUfKw3hKpYmXoe7wWyZ208ndkUXRV6n/jP/JLv+vVfBguKoQLFj25CKmPrE8bWNRQKodZLj+w FkfbIqPnuf6Qr80e5xF0XgI7WXVkGkY0lS1JKHx2ONUtAqdqvsxjACrex8KqKkenPLM38UypBW1 w== X-Received: by 2002:a05:693c:300c:b0:2d9:5cd9:b8ff with SMTP id 5a478bee46e88-304fa4a757dmr2802692eec.6.1780204432587; Sat, 30 May 2026 22:13:52 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:aa7b:13a9:ea74:503]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-304ed2c3121sm5667940eec.5.2026.05.30.22.13.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 May 2026 22:13:51 -0700 (PDT) Date: Sat, 30 May 2026 22:13:47 -0700 From: Dmitry Torokhov To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= Cc: Anshul Dalal , Michael Hennerich , Yassine Oudjana , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Support Opensource , Nick Dyer , Hans de Goede , Job Noorman , Mika =?utf-8?B?UGVudHRpbMOk?= , Maxime Coquelin , Alexandre Torgue , Kees Cook , bui duc phuc , Thorsten Blum , Yauhen Kharuzhy , Sakari Ailus , Marco Crivellari , Minseong Kim , Ingo Molnar , Thomas Gleixner , Oleh Kuzhylnyi , Marek Vasut , Krzysztof Kozlowski , Geert Uytterhoeven , Josua Mayer , Michael Tretter , Jeff LaBundy , Javier Carrasco , David Heidelberg , Petr Hodina , Svyatoslav Ryhel , Johannes Kirchmair , Andy Shevchenko , Xichao Zhao , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH v1] Input: Use named initializers for arrays of i2c_device_data Message-ID: References: <20260515164848.497608-2-u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sat, May 30, 2026 at 02:02:20PM +0200, Uwe Kleine-König (The Capable Hub) wrote: > Hello Dmitry, > > On Fri, May 29, 2026 at 10:56:48PM -0700, Dmitry Torokhov wrote: > > I like the ability to properly set up pointers for driver data, however > > I do not think we should use named initializers for name field. As long > > as we are not planning on moving its position I like the brevity of just > > saying > > > > { "ili210x", .driver_data_ptr = &ili210x_chip }, > > > > Can we keep the old style for the name field? > > I have no strong opinion here, my patch introduces the named initializer > for both members for consistency. Note that my patches for all the other > subsystems (and also other *_device_id) do the same and you're the first > maintainer with that expressed preference. > > I even sent a few patches that adapt initializers without .driver_data > (e.g. > https://lore.kernel.org/all/177932943265.3832404.360063047381979287.git-patchwork-notify@kernel.org/) > that got positive feedback so far. > > So if you're ok with having input differ in style from (up to now) all > other subsystems, I can rework the patch. OK, I guess I am too late to voice my opinion. I do not want to have different style, in this particular case at least, so I applied the patch. Thanks. -- Dmitry