From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 897724779A4; Wed, 3 Jun 2026 12:03:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780488188; cv=none; b=o5iK1UBwmVfHrU9e+xfPzrUp6XMGrbgAZtKR9iQEaJEv4jf7fbccMltGT5zjcxDFeOFUN+vZ7GoD1SFuDSMmciqzoF/WmN5v3OEBWwOTYadxfiA2Qct0pGDOK80kkMEbwcOeb/guB6Gdb72e3jnsv0U/E8q14L+0BQFTNYq5WDo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780488188; c=relaxed/simple; bh=iws0Tqy7tnfDb1/y0VXTMhiMiNB5jVzESMdnPftZQL8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eAUZVoe56pZBmjwu3kZ/It45GoBRKTH+xYgkNc0xJjqzsmkI+XUjo6EElSYRUQZ8FEgDoGhITWFYwlpDj9Rr3UP//++INnSMdCBI6WAPytXmoPecAIMiFMd/v7bpjLHS/mxR/BE+q+I1ZIFnMdPjEX/HY0YRW4ZdiMjoB7V2qh8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NwnnLw/I; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NwnnLw/I" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 996911F00893; Wed, 3 Jun 2026 12:03:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780488187; bh=IDHgSHa5uXJ+5Hto9fEJThy5rAbEZ0SR6ey5biY1EW0=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=NwnnLw/Id0sHKsjiKaS8e4ppA2aD9LcPMTcTIPRFSYWL7yOAwo+azmXyFJB9euTCq PtjT0r283OzRwfwqQzwW0Q61xedncBSgVLwQiMk4zPGOcq5VGRINV55mJXJmWUL98Q Ye0XW2PTKkw2NbjwguZT6ACC91Vd+LBufHEHsbBdqsmxlP/h00qyIE4QmiPzV5yJCa 1J8dsKBHHYbQ7JU73wzCbOoJUQD5qs2DyMaA1hfNDLlmQEqEHu98h7m3kDE/FePb3o KaE5QwbmnWgXlALze/3rs/VzhE6hqc9nIhLQmtwBk5wwJN/aqsUBlfJbS8luLI4Xmc 0zyIIHCMUywTg== Date: Wed, 3 Jun 2026 14:03:01 +0200 From: Benjamin Tissoires To: Andy Shevchenko Cc: Jiri Kosina , "Daniel J. Ogorchock" , Petr Mladek , Tamir Duberstein , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Jonathan Corbet , Shuah Khan , Andrew Morton Subject: Re: [PATCH v2 2/2] HID: nintendo: Use %pM format specifier for MAC addresses Message-ID: References: <20260603104351.152085-1-andriy.shevchenko@linux.intel.com> <20260603104351.152085-3-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260603104351.152085-3-andriy.shevchenko@linux.intel.com> On Jun 03 2026, Andy Shevchenko wrote: > Convert to %pM instead of using custom code. > > Signed-off-by: Andy Shevchenko Not sure where the first patch should land, so in case someone prefers having the full series through their tree: Acked-by: Benjamin Tissoires Cheers, Benjamin > --- > drivers/hid/hid-nintendo.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/hid/hid-nintendo.c b/drivers/hid/hid-nintendo.c > index 29008c2cc530..05c50f2530ef 100644 > --- a/drivers/hid/hid-nintendo.c > +++ b/drivers/hid/hid-nintendo.c > @@ -2431,14 +2431,8 @@ static int joycon_read_info(struct joycon_ctlr *ctlr) > for (i = 4, j = 0; j < 6; i++, j++) > ctlr->mac_addr[j] = report->subcmd_reply.data[i]; > > - ctlr->mac_addr_str = devm_kasprintf(&ctlr->hdev->dev, GFP_KERNEL, > - "%02X:%02X:%02X:%02X:%02X:%02X", > - ctlr->mac_addr[0], > - ctlr->mac_addr[1], > - ctlr->mac_addr[2], > - ctlr->mac_addr[3], > - ctlr->mac_addr[4], > - ctlr->mac_addr[5]); > + ctlr->mac_addr_str = devm_kasprintf(&ctlr->hdev->dev, GFP_KERNEL, "%pMU", > + ctlr->mac_addr); > if (!ctlr->mac_addr_str) > return -ENOMEM; > hid_info(ctlr->hdev, "controller MAC = %s\n", ctlr->mac_addr_str); > -- > 2.50.1 > >