From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f180.google.com (mail-dy1-f180.google.com [74.125.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C26920DD51 for ; Thu, 25 Jun 2026 23:45:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782431141; cv=none; b=ovaNh3O6Ku94IECBunsq10ObNVJP1DIEPJOEH0/igXQeST2CWhk5gChT5JwNcbkWPn8vef7zbB+koi49nhvgRUv0sn6E/w8XvAziUQgLOqJqgTrVyZMt6zWNjG3XrHPq+eB2JkmK+zE3d7ekASodsAcmiaxlL4YvClTsOH3dWWc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782431141; c=relaxed/simple; bh=zho+bds/K3sr8/g+6AtV9BHLkTqIWWluRxW2zUqjJmk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QpNaS1OTSU6KBEedImXJxFXQ8mgK9EYDf4rmnBTNykgxEtffpY0Mg7UPD5HGNqpECVK/dUHhAXyYufRkAekknjGXBhR9E6M3Hor4KGNKJkwGsEpgxf2emX+RNtK8M+L5zED6N4nlhdv3dLGKwbPA3ESzr0N9Lrp4I3MJ1AIT9p4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HX1UzVmN; arc=none smtp.client-ip=74.125.82.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HX1UzVmN" Received: by mail-dy1-f180.google.com with SMTP id 5a478bee46e88-30bf132969bso654001eec.0 for ; Thu, 25 Jun 2026 16:45:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782431138; x=1783035938; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gAeg/0vb+Xz33u79vnkEfiy2hWyqVw1XPl1l+y0c8QQ=; b=HX1UzVmNIETGP/IykGirRUGNjgfm0ctMQ3Mfh3zMmVqAv93lLura1SJmNOZfKYKm0B 4FmSN4r9q7HNjcJwY0+bydn/2y96zkO06eVkNHrSuwc/Zpn1Od+sKAJtACnBiIYhL6uZ mN0RTe8ourxGZ8PZogtZFv68CaraMlrmwLFNedPdmowuutM/X+VlE8XeWXvewZ+fSXdi R8x0vEUZ1mWMjFe6tdp5/rtRAylgPraNhXCPmknqu5lm6s0hNv6bTCXRFwDCmvC588ik h1p05z207EBzsAV21ddAbrswgYC0sRoO5bs7R0hT1+/R5kvGHBvBkww948vEz2rxmsdy 8yzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782431138; x=1783035938; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gAeg/0vb+Xz33u79vnkEfiy2hWyqVw1XPl1l+y0c8QQ=; b=M98jqoB8Ye1+2zZ+1ioeCfz4N9dWK8aHTDoXHA5nYpfL0XN9Dx/7iaB9zDzmfLQuRf OD+jrubV2fXW5v0//HI9PA+pFq70EtpplfA5d4e6a40rVd3/Mlemibr25sTgW+jViks5 6gb7JL1AskM5G14O9aUNmP0JOnvw3ZoTpylp6rWAI2JiKfeWuhM/6bkUmXKNbydrpbZz yBXDu3Z2fhSUbGK1Nzg6O1Q6RP7WJ7IwxHsG41Ty2coutD4TZ273qkls10rHjHFSBGkw 4yGEyj8ap9Tx7PYRszzwcYoXDKFU2Q6gbWk/7TATsAkYXmfK6muI+eIcD57MyIvRFV7S BA8g== X-Forwarded-Encrypted: i=1; AHgh+RoioxlKqzOAmGwLjHZVlOYxdIu4ONAWyhUHznKMYCzW5U7W5Jq2ZhGoYdQJI7a+XdlYkD0kzu0P1SMTvg==@vger.kernel.org X-Gm-Message-State: AOJu0YyRclewEZSShKpTFiKzyc1H8pgjYPpWFFDlo/2rvnDAcvBn7OzV cU279lXjXMZvD07QE5TuYhi1bb8MrSZiaRpMTqUSShJOIQM/whvDS7NE X-Gm-Gg: AfdE7cneurftQiRFSaq7Ka2wv29YyuSHUFT/t6Qm6n33EL5MrJmeXS41hZKyaVhv9vm f0vuaYPLv91OjCyfY8MagAbNlkiNr1misQ+x7jgmbvbpIkvC+mcFYj3oQc3XNEMfFBMH6nBJ3kw TlH2uL4ofg9dYO7CGtAOut+ugRr43IZqLU6/WdnmlXihS8J9QX+lHag53+GnMSOPjIXZ3TnqXfg OuzbnJ4c2aHhvDQEIbll7WIX6VEfx6WCqndtY9mu22euc4Tt0B0T9X41vEtIIAWpzq+yriAS8ZQ j7hGmfHbqFe6YXkx+LX3TUkQGwSCxFK7xMAF0bV3jB+mEE72D1ddrW7BpyuCfW32Z12mJ8hJKB3 DlDtUe7bgvrqtoMuElxPEmyuktWbZT+6JWBxvbnfhoaVjJMNz3WaOXP7Rt7JKH1DW6exwPsUfAd EEx0R3/VdIpIr4bzVw58tpMs/bvF/GkrcgziLhoT5jWFdzshyF4QKtCg== X-Received: by 2002:a05:7300:760a:b0:30b:f0c6:12c8 with SMTP id 5a478bee46e88-30c84ba31edmr4946004eec.9.1782431138182; Thu, 25 Jun 2026 16:45:38 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:c782:a4ca:fcbd:6ba7]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30c7c8afc91sm12621344eec.14.2026.06.25.16.45.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2026 16:45:37 -0700 (PDT) Date: Thu, 25 Jun 2026 16:45:34 -0700 From: Dmitry Torokhov To: Svyatoslav Ryhel Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 2/2] Input: isa1200 - new driver for Imagis ISA1200 Message-ID: References: <20260617070528.35006-1-clamor95@gmail.com> <20260617070528.35006-3-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260617070528.35006-3-clamor95@gmail.com> Hi Svyatoslav, On Wed, Jun 17, 2026 at 10:05:27AM +0300, Svyatoslav Ryhel wrote: > From: Linus Walleij > > The ISA1200 is a haptic feedback unit from Imagis Technology using two > motors for haptic feedback in mobile phones. Used in many mobile devices > c. 2012 including Samsung Galxy S Advance GT-I9070 (Janice), Samsung Beam > GT-I8350 (Gavini), LG Optimus 4X P880 and LG Optimus Vu P895. > > The exact datasheet for the ISA1200 is not available; all data was modeled > based on available downstream kernel sources for various devices and > fragments of information scattered across the internet. > > Tested-by: Linus Walleij # GT-I9070 Janice > Signed-off-by: Linus Walleij > Co-developed-by: Svyatoslav Ryhel > Signed-off-by: Svyatoslav Ryhel Sashiko convinced me that using mutex_trylock() in the playback work handler will result in dropping requests and that we are safe not taking the lock there at all. Can you please try the following modification? diff --git a/drivers/input/misc/isa1200.c b/drivers/input/misc/isa1200.c index c61adc4b605c..fb7f68fa0a2b 100644 --- a/drivers/input/misc/isa1200.c +++ b/drivers/input/misc/isa1200.c @@ -253,15 +253,12 @@ static void isa1200_stop(struct isa1200 *isa) static void isa1200_play_work(struct work_struct *work) { struct isa1200 *isa = container_of(work, struct isa1200, play_work); - struct input_dev *input = isa->input; - - scoped_guard(mutex_try, &input->mutex) { - if (!isa->suspended) { - if (isa->level) - isa1200_start(isa); - else - isa1200_stop(isa); - } + + if (!READ_ONCE(isa->suspended)) { + if (isa->level) + isa1200_start(isa); + else + isa1200_stop(isa); } } If this works no need to resend, I'll fold on my side. Thanks. -- Dmitry