Linux Input/HID development
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Sanjay Chitroda <sanjayembeddedse@gmail.com>
Cc: "Jiri Kosina" <jikos@kernel.org>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] HID: iio: callback API signature match for usage_id
Date: Wed, 17 Jun 2026 18:52:51 +0300	[thread overview]
Message-ID: <ajLC09uEIOClVzEq@ashevche-desk.local> (raw)
In-Reply-To: <20260616-16-jun-hid-iio-u32-api-type-v1-0-952c74195f46@gmail.com>

On Tue, Jun 16, 2026 at 06:55:19PM +0530, Sanjay Chitroda wrote:
> 
> Most of HID IIO driver has correct 'u32' type of usage_id with
> https://lore.kernel.org/all/20260610-6-june-hid-iio-correct-usage-id-v2-0-c3c5f0720493@gmail.com/
> series which is applied on iio/testing branch.
> 
> On top of the same, this series updates remaining HID IIO drivers
> to use 'u32' for the usage_id parameter.
> 
> Pending list of HID IIO drivers are extracted with command line:
> find drivers/iio/ -type f -name "*hid*" | xargs grep -A 5 static | \
>     grep -E -A 5 "_proc_event\(|_capture_sample\(|_parse_report\(" --color | \
>     grep usage_id

I recommend to get used with `git grep ...` which is more powerful and much
faster (on a Git index).

	git grep -lw 'u[^3].* usage_id' -- drivers/iio/

for the list of files, and

	git grep -np -w 'u[^3].* usage_id' -- drivers/iio/

for a better view.

(It gives one false positive, though :-)

> This matches expected callback API type as HID usage IDs are
> defined as 32-bit values.
> 
> No functional changes are introduced.
> 
> Testing:
>   - Compiled with W=1 for each patch in the series

Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

Jonathan, it seems the missing part of the initial unification. Please, apply
to your testing branch.

-- 
With Best Regards,
Andy Shevchenko



      parent reply	other threads:[~2026-06-17 15:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-16 13:25 [PATCH 0/3] HID: iio: callback API signature match for usage_id Sanjay Chitroda
2026-06-16 13:25 ` [PATCH 1/3] iio: hid-sensor-temperature: use u32 instead of unsigned int Sanjay Chitroda
2026-06-16 13:39   ` sashiko-bot
2026-06-16 13:25 ` [PATCH 2/3] iio: hid-sensor-humidity: " Sanjay Chitroda
2026-06-16 13:50   ` sashiko-bot
2026-06-16 13:25 ` [PATCH 3/3] iio: hid-sensor-custom-intel-hinge: " Sanjay Chitroda
2026-06-17 15:52 ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ajLC09uEIOClVzEq@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=jikos@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=sanjayembeddedse@gmail.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox