From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f174.google.com (mail-dy1-f174.google.com [74.125.82.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 846F329ACDD for ; Wed, 24 Jun 2026 04:28:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782275294; cv=none; b=oYNtpOKTX5a5CTADeHf5+sVzlH5u7CSYPdk0WWtjU7PpkhvvGXRrS54rsQlMo23BbydwK0U/3DU97KDq56TcRQNAUcD3Hq0aOtx3EIVUxjZr0dsDgfs7UqhLiM46+hamq8SdkglUAyEpfHqOkOH6FFEINgls0pUhoVrhXIYmi5o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782275294; c=relaxed/simple; bh=CatfsTP8wXiX+fsqwI5MUAVJoIpCzIOidq0t0/coTaI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lfMM3f5qDIaqPBpz2aZ/OZLA/phhL7YVVp+jVR2CulRI4JlloJwWr/d/UakfQM7ZxSoPGeLG37k6OIXKJFhT8pYqaYHA/zc6MMCviM34RzDzNf77TYsf5MZao/nldxUEXGNgg8G3ZrDhEHP8wBMkdp7GQTEikl+ZISaqeZ/G9Zs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qYhKUN2J; arc=none smtp.client-ip=74.125.82.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qYhKUN2J" Received: by mail-dy1-f174.google.com with SMTP id 5a478bee46e88-30c23abc62eso609373eec.1 for ; Tue, 23 Jun 2026 21:28:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782275292; x=1782880092; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=EEdnK3yMj7vaMPJob7ZvZ1mk4WeNg/B5FxtgUQVR5Lw=; b=qYhKUN2JvsDeCQcXG2CFYYYHESi3M4W9NrqLLmN0s4K5e/6fumhDEwdAIa8weo7sNJ cTRw4u34s2QV1nP95cqA00iKK0rCYKBLwsbvIYJxQ+HkYzQLXpC9Tgj8A1SUhk2XSftu n+73V0qDaWHErvlo2PwDVVdDf1vuw4ceFaaGd1MmpjcmcGYmow7GfDYIYluy4fYzN3cu QLi5B5El+xhe34yu8zpIdDx2W8f6pJrNX6ta6XDAb2kRo8tIhU0QLRFiyvIfQqQapifL CtGAPc2wNo4vwMxsHgV9L4ahVyjQFTcNKbFjVvO5EGXUWOLB29zlpsUaUI0W+bi41i3m s+Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782275292; x=1782880092; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EEdnK3yMj7vaMPJob7ZvZ1mk4WeNg/B5FxtgUQVR5Lw=; b=ViUnDPoYWkphmxDLAa4k6IlboSJP4T2BbpLAelDC/zSr+kYE2IZ+OcYpoA2k91CsQj sUqGVe73ZA/Zq/7egIwByWLCJ8kUpWLQ2jU429WceY0/SOVprhe6GBpKK1jh+JytenPo UfVjMTylMPP9Vvj8/7PhAc4SRk5433o8az+to2pGodXuhEhY/qSqP44ShDJJrXpClvf/ UqeVCvA9KNsVKXF3ZGurnxSpd39HsgxK4hqtHL+A+3OdCcbvZvR6UpghzTn3KrvzKeKu D6UsS1RkAaNQ8z30kDngsPEwGnUuWiTANSv8VQm05PwqDj0ky1HeCIby3yQLSUPc0z2e uZRA== X-Forwarded-Encrypted: i=1; AHgh+RpBPRyp2RB+FWszsC9EgGxioe0zdGVP5PuFsPJWnYkZk+JQRWcr4WIJTUsLpIaqjDLWeORwJmx8CRbQew==@vger.kernel.org X-Gm-Message-State: AOJu0Yx73KwMydbKBeVVEA9MYSabT5QfnqAr5FEhS4lXvUm9uApzh3Wd ONE9m7AB1t3J6Kmbw+OyQbmKQCXMOqaNM9/PdQ0ET83D1gYzL3Xb5IsS X-Gm-Gg: AfdE7cnV8yi6vlmygI8Sc0HuPNS1cFiRQPkduXfdVAGFYcmFFjfLD8eQ/5l7FBoE+CK fUDBcEXoXp3su2hzrz4mJhMYFTVMu0mH18AayCZszzrblX0eQgVXjZ8VJ2rfzxF+GlxOspzhcJN ksJK3pvxuE4W5Hw12hgSqLE7Jwv37mmzFnrCM/TY+q5LM8LCwY3FqFhKoiHmV783zEmwALgKj5d 5GCpRoJDaPQ631rItPy1LTxA8CyztTDRhxQSfzpoIroBqHvTIZdK9rWREHijdTpCfd3jFQsh+gb 1NJkCsf+dZ7Ojv/cEYTc9fuVwv+VvMDDrmimeUgXEJ19G5kIIucxmmQS6vQoz9yNkhxUz+IunR6 2XV/xGMWPKNjHjoweT9ox+ekzeeMaYhMC2a3PyNHMv77da7/pHotKTJZ5/MQO5cCJviksnsjkTE LfLkh5ReabK1xoJgzleguxPYokZHBFfF6cY3wXTJHySe0gUSJPvzoJKQ== X-Received: by 2002:a05:7300:5415:b0:2ed:e14:7f5c with SMTP id 5a478bee46e88-30c68e42cfcmr2209522eec.32.1782275291490; Tue, 23 Jun 2026 21:28:11 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:6026:1e6d:4a80:9bd0]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30c6f4993a1sm640193eec.17.2026.06.23.21.28.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2026 21:28:10 -0700 (PDT) Date: Tue, 23 Jun 2026 21:28:07 -0700 From: Dmitry Torokhov To: David Heidelberg Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Jason A. Donenfeld" , Matthias Schiffer , Vincent Huang , Bjorn Andersson , Konrad Dybcio , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: sdm845-oneplus: Update compatible to include model Message-ID: References: <20260523-synaptics-rmi4-dt-v2-0-0645122babdc@ixit.cz> <20260523-synaptics-rmi4-dt-v2-2-0645122babdc@ixit.cz> <1d0e7e31-f808-4347-955a-7246dea208f5@ixit.cz> <742c7a13-9465-40e8-8990-e679712e9784@ixit.cz> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <742c7a13-9465-40e8-8990-e679712e9784@ixit.cz> Hi David, On Sun, Jun 21, 2026 at 07:11:45PM +0200, David Heidelberg wrote: > On 28/05/2026 00:13, David Heidelberg wrote: > > On 27/05/2026 23:56, Dmitry Torokhov wrote: > > > Hi David, > > > > > > On Sat, May 23, 2026 at 11:45:35AM +0200, David Heidelberg via B4 Relay wrote: > > > > From: David Heidelberg > > > > > > > > We know the driver is reporting s3706b, introduce the compatible so we > > > > can more easily introduce quirks for weird touchscreen replacements in > > > > followup series. > > > > > > > > Reviewed-by: Konrad Dybcio > > > > Signed-off-by: David Heidelberg > > > > --- > > > >   arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 2 +- > > > >   1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi > > > > b/arch/ arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi > > > > index 6b7378cf4d493..148164d456a5a 100644 > > > > --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi > > > > +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi > > > > @@ -475,17 +475,17 @@ bq27441_fg: bq27441-battery@55 { > > > >       }; > > > >   }; > > > >   &i2c12 { > > > >       status = "okay"; > > > >       clock-frequency = <400000>; > > > >       synaptics-rmi4-i2c@20 { > > > > -        compatible = "syna,rmi4-i2c"; > > > > +        compatible = "syna,rmi4-s3706b", "syna,rmi4-i2c"; > > > > > > So I believe we established that this device (s3706b) does not in fact > > > implement rmi4 protocol properly. Why do we have "syna,rmi4-i2c" as a > > > fallback? Shouldn't it be just "syna,rmi4-s3706b"? > > > > The vendor supplies s3706b which does implement the RMI4 properly. > > > > The 3rd party replacement impersonating original parts may not implement > > it properly, but I don't address this issue in this initial submission. > > > > With this compatible we know which original part is used by the vendor > > and installed in the phones, so later we can deduct specific sequences > > for the replacement aftermarket parts to keep phone touchscreen working > > same as they do on Android without affecting other devices. > > Hello Dmitry. > > May I ask what is currently preventing this series from moving forward? > > The first version was posted in 2023 [1]. I picked it up again in 2025 [2] > and am now on the 9th iteration (this patchset). At this point, the series > has been under discussion for well over a year, with relatively little > feedback and increasingly long gaps between review rounds. > > The current approach is based on the guidance I have received so far, > including suggestions from the device-tree maintainers. When concerns were > raised, I tried to address them and rework the series accordingly. > > What I am struggling with is understanding what specific issue still needs > to be resolved before these patches can be accepted. If there are remaining > requirements, objections to the approach, or technical concerns that I have > not addressed, I would appreciate having them stated explicitly so I can > work on them. > > I also split out the straightforward, self-contained changes in the hope > that at least those could progress independently while I continued working > on any follow-up requirements. However, even those patches do not appear to > be moving forward. > > Could you please clarify what outcome you would like to see from this > series, and what concrete changes would be required to get it accepted? I am still confused about how you want to differentiate between the full RMI4 support vs the OnePlus flavor. The "syna,rmi4-s3706b", as you mentioned, implements RMI4 protocol properly, so we do not need to actually have it documented neither in binding nor in DTS. The issue you have with after-market parts that are not compliant and we need to figure out how to deal with them. Inside the driver I essentially need a"incomplete protocol" flag that we can use to implement additional checks or skip known to be not implemented functions/queries. In DT we could introduce something like "oneplus,rmi4-i2c" that is decidedly not compatible with "syna,rmi4-i2c" and neither one should be a fallback for the other. This of course needs buy-in from DT maintainers. Does this make sense? Thanks. -- Dmitry