Linux Input/HID development
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: linux-input@vger.kernel.org
Subject: you should fix typo, "QT2160" versus "KEYBOARD_QT2160"
Date: Fri, 16 Jul 2010 04:39:38 -0400 (EDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.1007160434590.13824@lynx> (raw)


  not sure what you want to do with this, but there's a mismatch:

drivers/input/keyboard/Kconfig:
...
config QT2160
...

  while the corresponding Makefile contains:

obj-$(CONFIG_KEYBOARD_QT2160)           += qt2160.o
             ^^^^^^^^^

  normally, i'd just edit the Kconfig file to be consistent with all
other config entries in that file, but:

$ grep -rw CONFIG_QT2160 *
arch/powerpc/configs/pasemi_defconfig:# CONFIG_QT2160 is not set
arch/powerpc/configs/44x/sam440ep_defconfig:# CONFIG_QT2160 is not set
arch/powerpc/configs/44x/icon_defconfig:# CONFIG_QT2160 is not set
arch/powerpc/configs/wii_defconfig:# CONFIG_QT2160 is not set
arch/powerpc/configs/85xx/stx_gp3_defconfig:# CONFIG_QT2160 is not set
arch/powerpc/configs/ppc64e_defconfig:# CONFIG_QT2160 is not set
arch/powerpc/configs/mpc512x_defconfig:# CONFIG_QT2160 is not set
arch/mips/configs/fuloong2e_defconfig:# CONFIG_QT2160 is not set
arch/mips/configs/mtx1_defconfig:# CONFIG_QT2160 is not set
arch/sparc/configs/sparc64_defconfig:# CONFIG_QT2160 is not set
arch/avr32/configs/atstk1006_defconfig:# CONFIG_QT2160 is not set
arch/avr32/configs/atstk1002_defconfig:# CONFIG_QT2160 is not set
arch/blackfin/configs/BF548-EZKIT_defconfig:# CONFIG_QT2160 is not set
... etc etc ...

  i'll let you decide how to resolve that.

rday

-- 

========================================================================
Robert P. J. Day                               Waterloo, Ontario, CANADA

        Top-notch, inexpensive online Linux/OSS/kernel courses
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

             reply	other threads:[~2010-07-16  8:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-16  8:39 Robert P. J. Day [this message]
2010-07-16 23:15 ` [PATCH] trivial: rename config-token QT2160 Christoph Fritz
2010-07-17 21:29   ` Dmitry Torokhov
2010-07-17 21:35     ` Robert P. J. Day
2010-07-17 23:56       ` Christoph Fritz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1007160434590.13824@lynx \
    --to=rpjday@crashcourse.ca \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox