From: Julia Lawall <julia.lawall@lip6.fr>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Himangi Saraogi <himangi774@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: touchscreen : Introduce the use of the managed version of kzalloc
Date: Thu, 29 May 2014 09:20:20 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.02.1405290919110.1996@localhost6.localdomain6> (raw)
In-Reply-To: <20140529071510.GF11817@core.coreip.homeip.net>
> > @@ -618,39 +619,22 @@ static int mrstouch_probe(struct platform_device *pdev)
> > input_set_abs_params(tsdev->input, ABS_PRESSURE,
> > MRST_PRESSURE_MIN, MRST_PRESSURE_MAX, 0, 0);
> >
> > - err = request_threaded_irq(tsdev->irq, NULL, mrstouch_pendet_irq,
> > - IRQF_ONESHOT, "mrstouch", tsdev);
> > + err = devm_request_threaded_irq(&pdev->dev, tsdev->irq, NULL,
> > + mrstouch_pendet_irq, IRQF_ONESHOT,
> > + "mrstouch", tsdev);
> > if (err) {
> > dev_err(tsdev->dev, "unable to allocate irq\n");
> > - goto err_free_mem;
> > + return -ENOMEM;
>
> This is bad conversion. We used to report 'err' returned by
> request_threaded_irq, but now we always report -ENOMEM. I fixed it up
> here and in other places and applied.
Sorry to have missed that. I guess you got the one on the call to
mrstouch_adc_init as well?
thanks,
julia
next prev parent reply other threads:[~2014-05-29 7:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 18:02 [PATCH] Input: touchscreen : Introduce the use of the managed version of kzalloc Himangi Saraogi
2014-05-29 7:15 ` Dmitry Torokhov
2014-05-29 7:20 ` Julia Lawall [this message]
2014-05-29 7:28 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1405290919110.1996@localhost6.localdomain6 \
--to=julia.lawall@lip6.fr \
--cc=dmitry.torokhov@gmail.com \
--cc=himangi774@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox