From: David Rientjes <rientjes@google.com>
To: Yongtaek Lee <ytk.lee@samsung.com>
Cc: rydberg@euromail.se, dmitry.torokhov@gmail.com,
daniels@collabora.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: evdev - Fix incorrect kfree of err_free_client after vzalloc
Date: Wed, 11 Jun 2014 23:49:02 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1406112348430.23724@chino.kir.corp.google.com> (raw)
In-Reply-To: <1402537537-17945-1-git-send-email-ytk.lee@samsung.com>
On Thu, 12 Jun 2014, Yongtaek Lee wrote:
> This bug was introduced by commit 92eb77d ("Input: evdev - fall back
> to vmalloc for client event buffer").
>
> vzalloc is used to alloc memory as fallback in case of failure
> of kzalloc. But err_free_client was not considered on below case.
> 1. kzalloc fail
> 2. vzalloc success
> 3. evdev_open_device fail
> 4. kfree
>
> So that address checking is needed to call correct free function.
>
> Signed-off-by: Yongtaek Lee <ytk.lee@samsung.com>
> Reviewed-by: Daniel Stone <daniels@collabora.com>
Acked-by: David Rientjes <rientjes@google.com>
next prev parent reply other threads:[~2014-06-12 6:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 1:45 [PATCH] Input: evdev - Fix incorrect kfree of err_free_client after vzalloc Yongtaek Lee
2014-06-12 6:49 ` David Rientjes [this message]
2014-06-20 14:14 ` David Herrmann
2014-06-23 1:12 ` Yongtaek Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1406112348430.23724@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=daniels@collabora.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
--cc=ytk.lee@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox