From: Julia Lawall <julia.lawall@lip6.fr>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Himangi Saraogi <himangi774@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt/sparc: Introduce the use of the managed version of kzalloc
Date: Fri, 23 May 2014 07:35:47 +0800 (SGT) [thread overview]
Message-ID: <alpine.DEB.2.10.1405230735060.2606@hadrien> (raw)
In-Reply-To: <alpine.DEB.2.10.1405230700090.2606@hadrien>
On Fri, 23 May 2014, Julia Lawall wrote:
>
>
> On Thu, 22 May 2014, Dmitry Torokhov wrote:
>
> > Hi Himangi,
> >
> > On Fri, May 23, 2014 at 01:04:30AM +0530, Himangi Saraogi wrote:
> > > This patch moves data allocated using kzalloc to managed data allocated
> > > using devm_kzalloc and cleans now unnecessary kfrees in probe and remove
> > > functions. Also the unnecessary labels are done away with.
> >
> > Please no more partial devm conversions. I am not interested in patches
> > that change only 1 resource to be managed and leaving the rest as is.
> >
> > If you want to do devm conversion please do it if you convert all (or at
> > least majority) of resource handling to managed resources.
>
> Sorry, I don't think we are clear on what is wanted. Himangi's patches
> convert everything where a devm function is already available (to our
> knowledge). Do you prefer that new devm functions be introduced? On the
> one hand, that is perhaps useful from a safety point of view. On the
> other hand, it could lead to a huge number of rarely used devm functions
> that no one knows about and to a lot of code diversity. So I don't know
> what is the good solution.
I guess that the concrete problem is of_ioremap? Since that is a pretty
common function, I guess it could be reasonable to introduce a devm
function for it as well. Or maybe one already exists and we overlooked
it.
julia
prev parent reply other threads:[~2014-05-22 23:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 19:34 [PATCH] dt/sparc: Introduce the use of the managed version of kzalloc Himangi Saraogi
2014-05-22 19:45 ` Dmitry Torokhov
2014-05-22 23:03 ` Julia Lawall
2014-05-22 23:14 ` Dmitry Torokhov
2014-05-23 0:07 ` Julia Lawall
2014-05-22 23:35 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1405230735060.2606@hadrien \
--to=julia.lawall@lip6.fr \
--cc=dmitry.torokhov@gmail.com \
--cc=himangi774@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox