From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Adrian Bunk <bunk@kernel.org>,
zippel@linux-m68k.org, sam@ravnborg.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Jiri Slaby <jirislaby@gmail.com>,
Mauro Carvalho Chehab <mchehab@redhat.com>
Subject: Re: [2.6 patch] HID: fix default building of all quirky devices
Date: Wed, 15 Oct 2008 10:17:27 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0810151009350.3288@nehalem.linux-foundation.org> (raw)
In-Reply-To: <alpine.LFD.2.00.0810151002120.3288@nehalem.linux-foundation.org>
On Wed, 15 Oct 2008, Linus Torvalds wrote:
>
> And notice how you mis-use select. That's not how to disable a question. A
> question gets disabled by just doing an "if xyz" on the question itself,
> like Adrian did.
Side note: Adrian too has a very odd and non-obvious way of doing this.
His patch did config entries like
config HID_BRIGHT
tristate "Bright" if EMBEDDED
default USB_HID
depends on USB_HID
which is a really odd way to express this. The much more natural one is
config HID_BRIGHT
tristate "Bright" if EMBEDDED
depends on USB_HID
default y
since there's no point in saying "default USB_HID" + "depends on USB_HID",
and that's just confusing. Since it depends on USB_HID, the "default y"
will automatically degrade to whatever USB_HID was set to.
Linus
next prev parent reply other threads:[~2008-10-15 17:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-15 4:13 usbhid_set_leds problems Adrian Bunk
2008-10-15 5:05 ` Adrian Bunk
2008-10-15 7:13 ` Jiri Kosina
2008-10-15 7:30 ` [2.6 patch] HID: fix default building of all quirky devices Adrian Bunk
2008-10-15 7:43 ` Jiri Kosina
2008-10-15 10:20 ` Adrian Bunk
2008-10-15 17:09 ` Linus Torvalds
2008-10-15 17:17 ` Linus Torvalds [this message]
2008-10-15 17:32 ` Adrian Bunk
2008-10-15 17:43 ` Linus Torvalds
2008-10-15 22:54 ` Jiri Kosina
2008-10-16 8:06 ` select validation (was: Re: [2.6 patch] HID: fix default building of all quirky devices) Geert Uytterhoeven
2008-10-16 18:47 ` Linus Torvalds
2008-10-16 19:31 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0810151009350.3288@nehalem.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=jirislaby@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=sam@ravnborg.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox