From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [2.6 patch] HID: fix default building of all quirky devices Date: Wed, 15 Oct 2008 10:43:36 -0700 (PDT) Message-ID: References: <20081015041346.GE4710@cs181140183.pp.htv.fi> <20081015050557.GB20183@cs181140183.pp.htv.fi> <20081015073011.GE20183@cs181140183.pp.htv.fi> <20081015173245.GA19255@cs181140183.pp.htv.fi> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:45755 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752876AbYJORol (ORCPT ); Wed, 15 Oct 2008 13:44:41 -0400 In-Reply-To: <20081015173245.GA19255@cs181140183.pp.htv.fi> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Adrian Bunk Cc: Jiri Kosina , zippel@linux-m68k.org, sam@ravnborg.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Slaby , Mauro Carvalho Chehab On Wed, 15 Oct 2008, Adrian Bunk wrote: > > For me the more obvious way was what I did, but I agree that your > solution looks better. I guess the "more obvious" part simply depends on what you're used to. The "default y" + "depends on XYZ" thing is a rather common model, so I find it to not just be shorter, but also "more obvious", exactly because I've seen it before. Of course, the behaviour of 'default y' is much simpler (and _much_ more common!) for a bool than for a tristate, and the rules for tristate logic in general are obviously often a bit non-intuitive considering that we're almost always used to the binary kind, and then the fact that Kconfgi uses ternary logic has caused no end of hiccups. Linus