Re: [PATCH 1/2] hid: gyration remote support

[Jiri Kosina <jkosina@suse.cz>]

On Mon, 30 Jun 2008, Daniel Walker wrote:

> This adds in a quirk for the additional un-mapped buttons on the
> gyration MCE remote.
>
> Signed-off-by: Daniel Walker <dwalker@mvista.com>
> ---
> drivers/hid/hid-input-quirks.c |   28 ++++++++++++++++++++++++++++
> 1 files changed, 28 insertions(+), 0 deletions(-)
[ ... ]
> @@ -324,6 +347,9 @@ static int quirk_sunplus_wdesktop(struct hid_usage *usage, struct input_dev *inp
> #define VENDOR_ID_SUNPLUS			0x04fc
> #define DEVICE_ID_SUNPLUS_WDESKTOP		0x05d8
>
> +#define VENDOR_ID_GYRATION			0x0c16
> +#define DEVICE_ID_GYRATION_REMOTE		0x0002

Hi daniel,

thanks a lot for the patch. Could you please leave the order of these 
defines alphabetically sorted?

> static const struct hid_input_blacklist {
> 	__u16 idVendor;
> 	__u16 idProduct;
> @@ -353,6 +379,8 @@ static const struct hid_input_blacklist {
>
> 	{ VENDOR_ID_SUNPLUS, DEVICE_ID_SUNPLUS_WDESKTOP, quirk_sunplus_wdesktop },
>
> +	{ VENDOR_ID_GYRATION, DEVICE_ID_GYRATION_REMOTE, quirk_gyration_remote },
> +

And here too, please.

Thanks,

-- 
Jiri Kosina
SUSE Labs