From: Jiri Kosina <jkosina@suse.cz>
To: Jiri Slaby <jirislaby@gmail.com>, Alan Ott <alan@signal11.us>
Cc: Stephane Chatty <chatty@enac.fr>,
Marcel Holtmann <marcel@holtmann.org>,
simon.windows@gmail.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Bug in hidraw When a HID Device Contains Multiple Reports
Date: Tue, 27 Apr 2010 10:25:00 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1004271024140.7579@pobox.suse.cz> (raw)
In-Reply-To: <4BD69047.3010703@gmail.com>
On Tue, 27 Apr 2010, Jiri Slaby wrote:
> On 04/27/2010 12:34 AM, Alan Ott wrote:
> > Make hidraw not stick an extra byte on the beginning of an IN transfer
> > when a HID device contains multiple reports.
> ...
> > I have attached a patch which seems to take care of this problem. Please
> > let me know if I have completely misjudged the situation.
>
> Nope, your analysis is correct. It was introduced by me in 85cdaf524. I
> apparently forgot to change the hidraw case, so your fix is OK.
Yeah, the analysis is correct, thanks a lot for catching this Alan!
I have put
Acked-by: Jiri Slaby <jslaby@suse.cz>
to the patch and applied it.
Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
prev parent reply other threads:[~2010-04-27 8:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-26 22:34 [PATCH 1/1] Bug in hidraw When a HID Device Contains Multiple Reports Alan Ott
2010-04-27 7:20 ` Jiri Slaby
2010-04-27 8:25 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1004271024140.7579@pobox.suse.cz \
--to=jkosina@suse.cz \
--cc=alan@signal11.us \
--cc=chatty@enac.fr \
--cc=jirislaby@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=simon.windows@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).