Re: [PATCH 2nd attempt] HID: roccat: Add support for Isku keyboard

[Jiri Kosina <jkosina@suse.cz>]

On Thu, 24 Nov 2011, Stefan Achatz wrote:

> I mailed this patch in exactly identical form on 31.08.11
> but it hasn't been applied and I got no answer whatsoever.
> So that's a reminder if it has just been missed in the
> derangement at that time.
> 
> This patch adds support for Roccat Isku keyboard.
> Userland tools can be found at http://sourceforge.net/projects/roccat

I have now queued the patch.

> +config HID_ROCCAT_ISKU
> +	tristate "Roccat Isku keyboard support"
> +	depends on USB_HID
> +	depends on HID_ROCCAT
> +	---help---
> +	Support for Roccat Isku keyboard.
> +

Seeing the number of ROCCAT device drivers growing, I'd actually like to 
ask you whether it'd be possible to have just one driver (with just one 
Kconfig entry) for all the roccat devices (hid-roccat); this starts 
polluting the Kconfig space a little bit, and we don't want to push users 
to select each and every keyboard indeed. Our usual way is doing this on 
per-vendor basis.

Would you be able to implement this for the next merge window?

Thanks,

-- 
Jiri Kosina
SUSE Labs