From: Jiri Kosina <jkosina@suse.cz>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: add ThingM blink(1) USB LED support
Date: Mon, 21 Jan 2013 17:37:00 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.2.00.1301211714520.8266@pobox.suse.cz> (raw)
In-Reply-To: <1355859068-29927-1-git-send-email-vivien.didelot@savoirfairelinux.com>
On Tue, 18 Dec 2012, Vivien Didelot wrote:
> The ThingM blink(1) is an open source hardware USB RGB LED. It contains
> an internal EEPROM, allowing to configure up to 12 light patterns. A
> light pattern is a RGB color plus a fading time. This driver registers a
> LED class instance with additional sysfs attributes to support basic
> functions such as setting RGB colors, fading and playing. Other
> functions are still accessible through the hidraw interface.
>
> At this time, the only documentation for the device is the firmware
> source code from ThingM, plus a few schematics. They are available at:
>
> https://github.com/todbot/blink1
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> ---
> Documentation/ABI/testing/sysfs-driver-hid-blink1 | 25 ++
> MAINTAINERS | 5 +
> drivers/hid/Kconfig | 10 +
> drivers/hid/Makefile | 1 +
> drivers/hid/hid-blink1.c | 275 ++++++++++++++++++++++
hid-blink sounds too generic to me, taking into account that this is not
'generic HID blinking' framework, but rather a specific device driver for
a particular device.
So something like hid-thingm-blink sounds more reasonable to me.
[ ... snip ... ]
> diff --git a/drivers/hid/hid-blink1.c b/drivers/hid/hid-blink1.c
> new file mode 100644
> index 0000000..13025a8
> --- /dev/null
> +++ b/drivers/hid/hid-blink1.c
> @@ -0,0 +1,275 @@
> +/*
> + * ThingM blink(1) USB LED Driver
> + * Copyright (C) 2012 Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> + *
> + * This program is free software: you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation, either version 3 of the License, or
Linux Kernel is being shipped under GPL v2, without "or any later" clause
added. So I am afraid I can't merge the code with this license.
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2013-01-21 16:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 19:31 [PATCH] HID: add ThingM blink(1) USB LED support Vivien Didelot
2013-01-21 16:37 ` Jiri Kosina [this message]
2013-01-21 17:14 ` Vivien Didelot
2013-01-21 18:36 ` Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1301211714520.8266@pobox.suse.cz \
--to=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).