Re: [PATCH 14/14] HID: check for NULL field when setting values

[Jiri Kosina <jkosina@suse.cz>]

On Wed, 28 Aug 2013, Jiri Kosina wrote:

> From: Kees Cook <keescook@chromium.org>
> 
> Defensively check that the field to be worked on is not NULL.
> 
> Signed-off-by: Kees Cook <keescook@chromium.org>
> Cc: stable@kernel.org
> ---
>  drivers/hid/hid-core.c |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index 55798b2..192be6b 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -1206,7 +1206,12 @@ EXPORT_SYMBOL_GPL(hid_output_report);
>  
>  int hid_set_field(struct hid_field *field, unsigned offset, __s32 value)
>  {
> -	unsigned size = field->report_size;
> +	unsigned size;
> +
> +	if (!field)
> +		return -1;
> +
> +	size = field->report_size;

Kees,

do you actually see any way how field could ever be null in 
hid_set_field()?

-- 
Jiri Kosina
SUSE Labs