From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Kosina Subject: Re: [PATCH] Input: automatically set EV_ABS bit in input_set_abs_params Date: Fri, 10 Oct 2014 13:30:28 +0200 (CEST) Message-ID: References: <20141008165425.GA23281@dtor-ws> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from cantor2.suse.de ([195.135.220.15]:32960 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751922AbaJJLaa (ORCPT ); Fri, 10 Oct 2014 07:30:30 -0400 In-Reply-To: <20141008165425.GA23281@dtor-ws> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, Henrik Rydberg , Hans de Goede , David Herrmann , Benjamin Tissoires , linux-kernel@vger.kernel.org On Wed, 8 Oct 2014, Dmitry Torokhov wrote: > Let's automatically set EV_ABS bit in device's event type list when calling > input_set_abs_params() so that drivers do not have to do it explicitly. > > These calls are never in a hot paths so we won't lose much time by setting > the same bit several times. > > Signed-off-by: Dmitry Torokhov Makes sense. Acked-by: Jiri Kosina Thanks. > --- > drivers/input/input.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/input/input.c b/drivers/input/input.c > index 29ca0bb..d2e06cc 100644 > --- a/drivers/input/input.c > +++ b/drivers/input/input.c > @@ -498,7 +498,8 @@ void input_set_abs_params(struct input_dev *dev, unsigned int axis, > absinfo->fuzz = fuzz; > absinfo->flat = flat; > > - dev->absbit[BIT_WORD(axis)] |= BIT_MASK(axis); > + __set_bit(EV_ABS, dev->evbit); > + __set_bit(axis, dev->absbit); > } > EXPORT_SYMBOL(input_set_abs_params); -- Jiri Kosina SUSE Labs