From: Jiri Kosina <jkosina@suse.cz>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Peter Wu <peter@lekensteyn.nl>,
Nestor Lopez Casado <nlopezcasad@logitech.com>,
Peter Hutterer <peter.hutterer@who-t.net>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] HID: logitech-hidpp: prefix the name with Logitech
Date: Wed, 17 Dec 2014 10:38:10 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.2.00.1412171037200.1680@pobox.suse.cz> (raw)
In-Reply-To: <1418337599-10239-1-git-send-email-benjamin.tissoires@redhat.com>
On Thu, 11 Dec 2014, Benjamin Tissoires wrote:
> Current names are reported as "K750", "M705", and it can be misleading
> for the users when they look at their input device list.
>
> Prefixing the names with "Logitech " makes things better.
>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> ---
>
> Changes in v2:
> - renamed PREFIX_SIZE into PREFIX_LENGTH
> - changed "name_length + PREFIX_LENGTH;" into "PREFIX_LENGTH + name_length;"
> - rebased on Peter's last patch series
Ok, looks reasonable. I was waiting whether someone from Logitech would
comment on the prefix check that could be used other than "Logitech".
But we can add that later.
Applied to for-3.20/logitech, thanks.
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2014-12-17 9:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 22:39 [PATCH v2] HID: logitech-hidpp: prefix the name with Logitech Benjamin Tissoires
2014-12-12 11:35 ` Peter Wu
2014-12-17 9:38 ` Jiri Kosina [this message]
2014-12-17 15:28 ` Benjamin Tissoires
2014-12-19 10:53 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1412171037200.1680@pobox.suse.cz \
--to=jkosina@suse.cz \
--cc=benjamin.tissoires@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nlopezcasad@logitech.com \
--cc=peter.hutterer@who-t.net \
--cc=peter@lekensteyn.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).