From: Jiri Kosina <jikos@kernel.org>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: linux-input@vger.kernel.org, Vitaly Katraew <zawullon@gmail.com>
Subject: Re: [PATCH] HID: logitech: fix Dual Action gamepad support
Date: Tue, 16 Feb 2016 11:02:34 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.2.00.1602161102210.22700@cbobk.fhfr.pm> (raw)
In-Reply-To: <1455396111-2511-1-git-send-email-notasas@gmail.com>
On Sat, 13 Feb 2016, Grazvydas Ignotas wrote:
> The patch that added Logitech Dual Action gamepad support forgot to
> update the special driver list for the device. This caused the logitech
> driver not to probe unless kernel module load order was favorable.
> Update the special driver list to fix it. Thanks to Simon Wood for the
> idea.
>
> Cc: Vitaly Katraew <zawullon@gmail.com>
> Fixes: 56d0c8b7c8fb ("HID: add support for Logitech Dual Action gamepads")
> Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
> ---
> drivers/hid/hid-core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index c6f7a69..f16155f5 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -1897,6 +1897,7 @@ static const struct hid_device_id hid_have_special_driver[] = {
> { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_ELITE_KBD) },
> { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_CORDLESS_DESKTOP_LX500) },
> { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_EXTREME_3D) },
> + { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_DUAL_ACTION) },
> { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_WHEEL) },
> { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_RUMBLEPAD_CORD) },
> { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_RUMBLEPAD) },
Applied, thanks.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2016-02-16 10:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-13 20:41 [PATCH] HID: logitech: fix Dual Action gamepad support Grazvydas Ignotas
2016-02-16 10:02 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1602161102210.22700@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=notasas@gmail.com \
--cc=zawullon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).