From: Jiri Kosina <jikos@kernel.org>
To: Masaki Ota <012nexus@gmail.com>
Cc: benjamin.tissorires@redhat.com, peter.hutterer@who-t.net,
hdegoede@redhat.com, dmitry.torokhov@gmail.com,
linux-input@vger.kernel.org, masaki.ota@jp.alps.com,
naoki.saito@jp.alps.com
Subject: Re: [PATCH] Alps I2C HID Touchpad-Stick support
Date: Fri, 17 Jun 2016 23:54:52 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1606172353250.6874@cbobk.fhfr.pm> (raw)
In-Reply-To: <1466070357-5315-1-git-send-email-masaki.ota@jp.alps.com>
On Thu, 16 Jun 2016, Masaki Ota wrote:
> >From Masaki Ota <masaki.ota@jp.alps.com>
>
> <ChangeList>
> - Add hid-alps.c for Support Alps I2C HID Touchpad and Stick device.
> - Add hid-alps.txt to check this device spec.
> - Add Alps-JP vendor ID to hid-idh.h for support this device.
> - To build this module, add Alps module definition to Makefile.
>
> Signed-off-by: Masaki Ota <masaki.ota@jp.alps.com>
> ---
> Documentation/hid/hid-alps.txt | 139 +++++++++++
> drivers/hid/Kconfig | 8 +
> drivers/hid/Makefile | 1 +
> drivers/hid/hid-alps.c | 525 +++++++++++++++++++++++++++++++++++++++++
> drivers/hid/hid-ids.h | 2 +
You actually also should update hid_have_special_driver[] in hid-core.c to
make sure that generic driver doesn't override you. Given that I've missed
this and already applied your patch -- could you please send that as a
followup patch as well?
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2016-06-17 21:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 9:45 [PATCH] Alps I2C HID Touchpad-Stick support Masaki Ota
2016-06-17 21:24 ` Jiri Kosina
2016-06-17 21:54 ` Jiri Kosina [this message]
2016-06-21 3:39 ` Dmitry Torokhov
2016-06-21 4:43 ` Masaki Ota
2016-06-21 6:36 ` Dmitry Torokhov
2016-06-21 5:29 ` Masaki Ota
2016-06-21 7:35 ` Jiri Kosina
-- strict thread matches above, loose matches on Subject: below --
2016-06-16 8:26 Masaki Ota
2016-06-16 9:14 ` Jiri Kosina
2016-06-16 1:43 Masaki Ota
2016-06-16 1:51 ` Masaki Ota
2016-06-16 8:00 ` Jiri Kosina
2016-05-26 4:40 Masaki Ota
2016-05-26 11:12 ` Jiri Kosina
2016-05-26 18:54 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1606172353250.6874@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=012nexus@gmail.com \
--cc=benjamin.tissorires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=masaki.ota@jp.alps.com \
--cc=naoki.saito@jp.alps.com \
--cc=peter.hutterer@who-t.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).