From: Jiri Kosina <jikos@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Masaki Ota <012nexus@gmail.com>,
benjamin.tissorires@redhat.com, peter.hutterer@who-t.net,
hdegoede@redhat.com, linux-input@vger.kernel.org,
masaki.ota@jp.alps.com, naoki.saito@jp.alps.com
Subject: Re: [PATCH] Improve Alps HID Touchpad code
Date: Wed, 22 Jun 2016 00:38:46 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1606220036490.6874@cbobk.fhfr.pm> (raw)
In-Reply-To: <20160621223503.GA34772@dtor-ws>
On Tue, 21 Jun 2016, Dmitry Torokhov wrote:
> > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> > index 3cdbc4b..678d8bd 100644
> > --- a/drivers/hid/hid-core.c
> > +++ b/drivers/hid/hid-core.c
> > @@ -1772,7 +1772,8 @@ static const struct hid_device_id hid_have_special_driver[] = {
> > { HID_USB_DEVICE(USB_VENDOR_ID_A4TECH, USB_DEVICE_ID_A4TECH_RP_649) },
> > { HID_USB_DEVICE(USB_VENDOR_ID_ACRUX, 0x0802) },
> > { HID_USB_DEVICE(USB_VENDOR_ID_ACRUX, 0xf705) },
> > - { HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY, USB_VENDOR_ID_ALPS_JP, HID_ANY_ID) },
> > + { HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY, USB_VENDOR_ID_ALPS_JP,
> > + HID_DEVICE_ID_ALPS_U1_DUAL) },
On top of what Dmitry said, the above has been (corrupted) line-wrapped
(most likely by your mail client). Could you please fix that up while
fixing the rest of Dmitry's valuable review comments?
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2016-06-21 22:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 10:28 [PATCH] Improve Alps HID Touchpad code Masaki Ota
2016-06-21 22:35 ` Dmitry Torokhov
2016-06-21 22:38 ` Jiri Kosina [this message]
2016-06-22 2:48 ` Masaki Ota
2016-06-22 4:42 ` Masaki Ota
2016-06-23 0:08 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2016-06-22 4:11 Masaki Ota
2016-06-23 0:11 ` Dmitry Torokhov
2016-06-23 6:58 ` Jiri Kosina
2016-07-22 8:10 ` Masaki Ota
2016-07-27 14:12 ` Jiri Kosina
2016-06-21 8:14 Masaki Ota
2016-06-21 8:22 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1606220036490.6874@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=012nexus@gmail.com \
--cc=benjamin.tissorires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=masaki.ota@jp.alps.com \
--cc=naoki.saito@jp.alps.com \
--cc=peter.hutterer@who-t.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).