Re: [PATCH 063/141] HID: input: Fix fall-through warnings for Clang

Jiri Kosina
2020-11-25T13:04:40Z

On Fri, 20 Nov 2020, Gustavo A. R. Silva wrote:

> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a goto statement instead of letting the code fall
> through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/hid/hid-input.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> index 9770db624bfa..37601b800a2e 100644
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -743,6 +743,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
> field->flags |= HID_MAIN_ITEM_RELATIVE;
> break;
> }
> + goto unknown;
>
> default: goto unknown;

This makes my eyes hurt :) But adding the annotation would be ugly as
well, so let me just take it as-is.

Thanks,

--
Jiri Kosina
SUSE Labs