From: Jiri Kosina <jikos@kernel.org>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Jason Gerecke <killertofu@gmail.com>,
Linux Input <linux-input@vger.kernel.org>,
Ping Cheng <pinglinux@gmail.com>, Aaron Skomra <skomra@gmail.com>,
Jason Gerecke <jason.gerecke@wacom.com>
Subject: Re: [PATCH v3] HID: wacom: Improve generic name generation
Date: Thu, 20 Jul 2017 15:41:25 +0200 (CEST) [thread overview]
Message-ID: <alpine.LSU.2.20.1707201540560.4705@cbobk.fhfr.pm> (raw)
In-Reply-To: <20170629160739.GH26073@mail.corp.redhat.com>
On Thu, 29 Jun 2017, Benjamin Tissoires wrote:
> OTOH, I would think having a more generic approach would be fine:
> bool inline bool hid_is_using_driver(struct hid_device *hdev,
> struct hid_ll_driver *driver)
> {
> return dev->ll_driver == driver;
> }
>
> And we can start adding the various extern definitions of the
> ll_drivers in hid.h too...
>
> How does that sound? Jiri?
Yeah, I find it slightly ugly, but at least it's generic :)
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2017-07-20 13:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 21:19 [PATCH v3] HID: wacom: Improve generic name generation Jason Gerecke
2017-06-29 14:10 ` Benjamin Tissoires
2017-06-29 15:35 ` Jason Gerecke
2017-06-29 16:07 ` Benjamin Tissoires
2017-06-29 17:13 ` Jason Gerecke
2017-07-20 13:41 ` Jiri Kosina [this message]
2017-07-24 16:46 ` [PATCH v4 1/2] HID: introduce hid_is_using_ll_driver Jason Gerecke
2017-07-24 16:46 ` [PATCH v4 2/2] HID: wacom: Improve generic name generation Jason Gerecke
2017-07-26 11:02 ` Benjamin Tissoires
2017-07-27 13:15 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1707201540560.4705@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=jason.gerecke@wacom.com \
--cc=killertofu@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=pinglinux@gmail.com \
--cc=skomra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).