From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A83D36EA8D for ; Fri, 24 Jul 2026 19:24:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784921049; cv=none; b=CXkAKFlykIWqnEg6FGDqLeX4NA52uUA60Fn+SHukjh+sJApbYXUZULRt0H9pb88JKohe8BXfJOSLEl6Ibpd5xFZdpKlslRCWXs5BA1/TqRiVj6YxAMYMtU++IZo5uVqDJ/OS0FUJ1MgCDZk/Yvjpr79Vm3lNwM4yAnElAoTOkPU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784921049; c=relaxed/simple; bh=hieC/kyuGvbUOouu6D2lYg+NmV0Y0CqegVgla8HlJRo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qpewUXRCIJHJ1xHQzqtd8xRbXIRdZICemzVWoLrjktWovccGfex4blHG8ViwcyLsQK/kM//jQUmV5VM2hPSnnSDdBAQ0RWhgPvsOG5PsWmOTfYziGaGIiNgMQ8r0sTlJPTFKzxWIeEhKZck5WZXFCu9aHvBULPKxIuXAm+vjbrs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qS6GaHjm; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qS6GaHjm" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-cbb8b54fcf8so925069a12.0 for ; Fri, 24 Jul 2026 12:24:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784921047; x=1785525847; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=wzWZ3WF1iTTyJII+h6wIVAKbIfkK/TqWCpKjALnDATk=; b=qS6GaHjm+EtoF58nzoqgbIQJjCta0wGM+sc856WkYhg3KbaTl/fmLddXsedzDEHNxA SF/jnMk2ESZr3MMcE/qDPRC6LQjUXYN6aYP6iNa07l+tuOFUba+ydNcs+UbvxNlhv9xE 9JVeIVAhTMLX5J7lZNI0EqBcIIGqjHHHmDxo6UF30/QSm+jfecKMJhVhwbi2K28tKXrr tifFXagMx5aPTKwehGI+uHgd7bSbVAHu/AsmW2LSzUhvNA2bNl7XcsYOFk7l46jPGw6K 45sVvVdu5YlXZZUchGJcUT9IVcRZ6ogqJFizEuvH5Kq5u36lMQFok9EyERUt+1j4WAiQ HBfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784921047; x=1785525847; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wzWZ3WF1iTTyJII+h6wIVAKbIfkK/TqWCpKjALnDATk=; b=UjOPpyCT5mFT9Zb2iZspYFqrV1MRUdC/PwLVhmQeD/QG8TBX0xkUpRhHr1Iyw3d/Ft AAqaHtfvg9mpj8kv06O9mzoFqx/loN5HUtjCRC2kSzlbpKTMce00Go6r3nn2OcfD6P1X QNrmKqxSarX0yt1VMb0Ve8uReGU5Nzq1z0y6r/XeHDnZq2gGd+ZGLpLglTIXSHedeO2U yI+WKjK2L5sEa6ESsvlj8xXXbTVvceQnXFUluLbpY/ZFgKvyVPG1eQbH7SgswT38qian JYLkHbwH7+fHBZF+QQAEqGFjA/dBl7vT37EyZmnnRdLMkr7foprw3D6u9Ad7/Dtl7CrN vziQ== X-Forwarded-Encrypted: i=1; AHgh+RoiY8lCI+LszNPnGEMyXrAKHNMs+RnjzZLx/yC0cAlf/BtkADT7pMY5qWjDZ4H+trwg4Bl3ibTlg4fbAA==@vger.kernel.org X-Gm-Message-State: AOJu0Yy2VOJSwauNrkcbDyAqrN9I2m1h+nWGGCjqxkJ4m6z22B94YOma QTQkPYZMKWs+dLP9YHtoyGGD9+HE7qPQtaeiM/Ge+AxIAjGsfeLqme1v X-Gm-Gg: AR+sD12tdiIlkKUkwWyQLajIZyuXkxIq+w0v+wMEDPAM88gZd3braVMUdtqg0Csqpwn Vax6uyYrkrDDa9Y4mJ35Fajvrcy8V4oI+q8aqI+WZvyNoHe+Ia8pbblc/AD/S8om2/Bgt4qVShN pB5/RuLQGUEAEN3mmF70b4xl5OF2dPgrFwQYD2XLCOCtutjYRt+VvfrIu5TiEWqU6ZernQhH8yz JAFmXJMzcZ5Bgv3D06DCdVcLYuk1B+LmOhBTZulBDthvu4aYvFm+P34D4cOwSBRaOskv22I/50Z aKRqEwfU5Arg5plWPVUmduurbXwVYcSWBmC0xMZNPsHWJElBP8tUx5iRyd4FvAoKmToc5W27pdx 6JjPmeZVOs3tfemMo1OA8HaH2HR/+GVbqTPP0Mw7zH/HU8PL4axRWnG0Cu8wk15oJJQ6nqD57l8 4PimSwP5nOPlRyhwDHydUdTcWw4XCwj0mroIFR8+FVCv8ugteSiiWuzQ== X-Received: by 2002:a05:6300:408a:b0:3c3:a3fd:db0a with SMTP id adf61e73a8af0-3c44afda117mr9145039637.16.1784921046575; Fri, 24 Jul 2026 12:24:06 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:40e1:40e4:dabe:543e]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-314bc3e127asm3436937eec.2.2026.07.24.12.24.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 12:24:05 -0700 (PDT) Date: Fri, 24 Jul 2026 12:24:01 -0700 From: Dmitry Torokhov To: Kaustabh Chakraborty Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Srba , Linus Walleij , Peter Griffin , Alim Akhtar , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH 2/5] Input: zinitix - do not ignore non-moving fingers Message-ID: References: <20260724-zinitix-modes-v1-0-f6df7d86a878@disroot.org> <20260724-zinitix-modes-v1-2-f6df7d86a878@disroot.org> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260724-zinitix-modes-v1-2-f6df7d86a878@disroot.org> Hi Kaustabh, On Fri, Jul 24, 2026 at 12:54:04AM +0530, Kaustabh Chakraborty wrote: > With the ZT7548 touchscreen present in the Galaxy J6, multitouch does not > work reliably. This is due to the fact that the driver reports fingers > only when their state is changed, so it's either placed against the > scren, moved, or drawn away from the screen. > > The function which is responsible for this is zinitix_report_finger(). > This function is called from the IRQ handler, under the following > condition: > > if (p->sub_status & SUB_BIT_EXIST) > zinitix_report_finger(bt541, i, p); > > This implies and ensures that every valid finger must have the > SUB_BIT_EXIST flag. > > However, at the beginning of the function, it refuses to recognize any > finger if it has none of SUB_BIT_UP | SUB_BIT_DOWN | SUB_BIT_MOVE. This > excludes fingers in reports which do not move from the position since > the previous interrupt. Add SUB_BIT_EXIST to the list of valid bits. This makes the check basically a no-op as SUB_BIT_EXIST would always be set when we reach this function. It may very well be that we want to delete this check altogether, or maybe we need to add SUB_BIT_UPDATE and SUB_BIT_WAIT. I am curious what status bits you see when this condition (original) triggers for you... > > Signed-off-by: Kaustabh Chakraborty > --- > drivers/input/touchscreen/zinitix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/zinitix.c b/drivers/input/touchscreen/zinitix.c > index 3421b8ffb19b..fdcb80f52c91 100644 > --- a/drivers/input/touchscreen/zinitix.c > +++ b/drivers/input/touchscreen/zinitix.c > @@ -406,7 +406,7 @@ static void zinitix_report_finger(struct bt541_ts_data *bt541, int slot, > u16 x, y; > > if (unlikely(!(p->sub_status & > - (SUB_BIT_UP | SUB_BIT_DOWN | SUB_BIT_MOVE)))) { > + (SUB_BIT_EXIST | SUB_BIT_UP | SUB_BIT_DOWN | SUB_BIT_MOVE)))) { > dev_dbg(&bt541->client->dev, "unknown finger event %#02x\n", > p->sub_status); > return; > Thanks. -- Dmitry