Linux Input/HID development
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Myeonghun Pak <mhun512@gmail.com>
Cc: Linus Walleij <linusw@kernel.org>,
	 Samuel Ortiz <sameo@linux.intel.com>,
	Rabin Vincent <rabin.vincent@stericsson.com>,
	 linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] Input: stmpe-keypad - disable keypad on probe failure
Date: Tue, 4 Aug 2026 21:33:48 -0700	[thread overview]
Message-ID: <anK82Y-C2GCd2cBP@google.com> (raw)
In-Reply-To: <20260804141525.39388-1-mhun512@gmail.com>

Hi Myeonghun,

On Tue, Aug 04, 2026 at 11:15:25PM +0900, Myeonghun Pak wrote:
> stmpe_keypad_chip_init() enables the keypad block before programming
> its registers. If any subsequent register access fails, the function
> returns without disabling the block. The later IRQ request and input
> device registration failures have the same problem.

What exactly is the problem with leaving keyboard block enabled? 

Thanks.

-- 
Dmitry

      parent reply	other threads:[~2026-08-05  4:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04 14:15 [PATCH] Input: stmpe-keypad - disable keypad on probe failure Myeonghun Pak
2026-08-04 15:15 ` sashiko-bot
2026-08-05  4:33 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=anK82Y-C2GCd2cBP@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=linusw@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhun512@gmail.com \
    --cc=rabin.vincent@stericsson.com \
    --cc=sameo@linux.intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox