From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Esben Haabendal <esben@geanix.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org,
Esben Haabendal <esbenhaabendal@gmail.com>
Subject: Re: [PATCH] Input: gpio_decoder - fix bit order reversal introduced by bitmap conversion
Date: Mon, 17 Aug 2026 16:37:13 +0300 [thread overview]
Message-ID: <aoMOiZNrbOtRgXu-@ashevche-desk.local> (raw)
In-Reply-To: <20260817-gpio-decoder-bitrev-v1-1-6ffb77e323b8@geanix.com>
On Mon, Aug 17, 2026 at 01:50:27PM +0200, Esben Haabendal wrote:
> The switch from a manual loop to gpiod_get_array_value_cansleep() +
> bitmap_read() inadvertently reversed the bit order of the decoded value.
> The original loop treated GPIO[0] as MSB by shifting left on each
> iteration, but bitmap_read() returns GPIO[0] at bit 0 (LSB).
>
> The previous bit order was correct according to device-tree bindings, and
> the change broke existing users.
Oops, thanks for catching this!
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-08-17 13:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 11:50 [PATCH] Input: gpio_decoder - fix bit order reversal introduced by bitmap conversion Esben Haabendal
2026-08-17 13:37 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoMOiZNrbOtRgXu-@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=esben@geanix.com \
--cc=esbenhaabendal@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox