Re: [PATCH v2] HID: input: map System Microphone Mute LED

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Fri, Sep 11, 2026 at 05:58:24PM +0200, Jiri Kosina wrote:
> On Fri, 4 Sep 2026, Jonathan Jansen wrote:
> 
> > HUTRR110 defines LED page usage 0x57 as System Microphone Mute.
> > 
> > The usage is currently ignored, so the indicator stays dark and
> > userspace falls back to per-vendor code in hid-lenovo,
> > hid-playstation, hid-plantronics.
> > 
> > Map it to a new LED_MICMUTE. It appears as
> > /sys/class/leds/inputN::micmute and uses the "audio-micmute"
> > trigger from snd-ctl-led, so the LED follows the system-wide
> > mic mute state the same way LED_MUTE (page 0x09) already does
> > for speaker mute.
> > 
> > LED_MICMUTE takes the next free code (0x0b).
> > 
> > Link: https://www.usb.org/sites/default/files/hutrr110-systemmicrophonemute.pdf
> > 
> > Signed-off-by: Jonathan Jansen <jonathanjansen@ait.place>
> > ---
> > 
> > Notes:
> >     Changes since v1: rewrote the commit message; no functional changes.
> > 
> >  drivers/hid/hid-debug.c                | 2 +-
> >  drivers/hid/hid-input.c                | 1 +
> 
> Acked-by: Jiri Kosina <jkosina@suse.com>
> 
> for the drivers/hid changes.
> 
> Dmitry, will you take this through your tree, please?

Hi Jiri, Jonathan,

Sorry but we should not add any new LED definitions to input since we
have proper LED subsystem now. The existing LED definitions are strictly
legacy now and input core has a bridge to LEDs (in input-leds.c).

I see we had similar submissions in '23 and '24 at the very least. I
should add a comment to that effect to input-event-codes.h.

Thanks.

-- 
Dmitry