Re: [PATCH v2] Input: s6sy761 - fix resume ordering and restore sensing

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Sat, Sep 26, 2026 at 08:37:44PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] input: permanent IRQ disable on s6sy761_power_on() failure
> --
> 
> commit e5e3e44a0960351c54b4dc02894567b7b504952c
> Author: David Heidelberg <david@ixit.cz>
> 
> Input: s6sy761 - fix resume ordering and restore sensing
> 
> This commit alters the resume ordering to power on the controller before
> unmasking the interrupt, addressing an issue where the boot-complete
> event was consumed prematurely. It also ensures SENSE_ON is re-sent upon
> resume if the input device is already open.
> 
> > diff --git a/drivers/input/touchscreen/s6sy761.c b/drivers/input/touchscreen/s6sy761.c
> > index 0f24a9b730635..899c179fb2d31 100644
> > --- a/drivers/input/touchscreen/s6sy761.c
> > +++ b/drivers/input/touchscreen/s6sy761.c
> > @@ -500,10 +500,22 @@ static int s6sy761_suspend(struct device *dev)
> >  static int s6sy761_resume(struct device *dev)
> >  {
> >  	struct s6sy761_data *sdata = dev_get_drvdata(dev);
> > +	int err;
> > +
> > +	err = s6sy761_power_on(sdata);
> > +	if (err)
> > +		return err;
> 
> [Severity: Medium]
> Will this early return permanently disable the interrupt if power on fails?
> 
> If s6sy761_power_on() fails (for example, due to a transient I2C error
> during resume), this early return skips enable_irq(). However, the PM core
> will still clear the suspended state despite the error.

It looks like the PM core never implemented properly trackign device
state and not calling suspend on devices that has not resumed. That
means that we need to do it ourselves. We definitely do not want to keep
interrupts enabled if powering up the device failed.

I'll send out a patch fixing this.

Thanks.

-- 
Dmitry