Re: [PATCH v3 2/2] Input: gpio-keys - support wakeup pinctrl state on suspend

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

Hi Kendall,

On Thu, Oct 01, 2026 at 11:12:31AM -0500, Kendall Willis wrote:
> Pinctrl is optional to use for gpio-keys so we only care if
> -EPROBE_DEFER is the error from pinctrl which would mean that it just
> has not been probed yet. All other errors can fall through and the
> pinctrl_wakeup variable would be left as NULL.

If pinctrl is not specified, devm_pinctrl_get() returns -ENODEV (or NULL
if !CONFIG_PINCTRL). Other errors (-ENOMEM, -EINVAL) indicate genuine
issues that should not be swallowed.

Please reset ddata->pinctrl to NULL, ignore -ENODEV, and propagate any
other errors:

	ddata->pinctrl = devm_pinctrl_get(dev);
	if (IS_ERR(ddata->pinctrl)) {
		error = PTR_ERR(ddata->pinctrl);
		ddata->pinctrl = NULL;

		if (error != -ENODEV)
			return dev_err_probe(dev, error,
					     "Failed to get pinctrl\n");
	}

Thanks.

-- 
Dmitry